1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
phorge-phorge/src
epriestley b757e5c302 Use "MethodCallFuture" to move Diffusion Conduit exceptions to resolution time
Summary:
Depends on D21720. Ref T13666. See D21720 for additional discussion.

Use "MethodCallFuture", introduced in D21720, so that exceptions raised in "execute()" are thrown when the future is resolved, not when the future is created.

This makes exception behavior for clustered and non-clustered setups consistent, and chooses the intended (clustered) behavior in both cases, which currently deals with errors better.

Test Plan:
  - Applied both parts of the patch in T13666 (break history queries, force immediate futures) to reproduce the issue in T13666.
    - Loaded a Diffusion landing page, reproduced the error described in that task.
  - Applied this patch, verified landing page works again.
  - Removed the "break history queries" change, verified landing page works in forced-immediate mode.
  - Removed the "force immediate" change, verified landing page works in "actual future" mode.

Reviewers: cspeckmim

Reviewed By: cspeckmim

Maniphest Tasks: T13666

Differential Revision: https://secure.phabricator.com/D21721
2021-09-04 14:36:41 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom Sites 2021-03-11 14:05:39 -08:00
applications Use "MethodCallFuture" to move Diffusion Conduit exceptions to resolution time 2021-09-04 14:36:41 -07:00
docs Remove some "Phacility" and "epriestley" references 2021-07-08 10:46:17 -07:00
extensions
infrastructure Add an "eval" rule to Remarkup 2021-07-29 16:46:50 -07:00
view Replace Differential "unit stars" with icons 2021-03-17 13:45:52 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Add an "eval" rule to Remarkup 2021-07-29 16:46:50 -07:00