mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-27 07:50:57 +01:00
305fb3fbd9
Summary: Ref T2222. Currently, `DifferentialComment` stores both (a) the text of comments and (b) various other transaction details. This data needs to map to both Transactions and TransactionComments in the long run. This diff separates out all the data which is bound for the TransactionComment table, so that when we migrate `DifferentialComment` itself it will //only// need to migrate into the Transactions table. This is a much simpler migration than the inline comment one was, partly because it set up infrastructure and partly because the data is less complex. Basically, I'm just proxying the read/write for the comment text into the other table. All readers already go through the Query class, and there are only three writers (preview, comment, implicit comment on diff update) which are all highly regular and straightforward to test. We can also back out of this diff very easily: doing double writes cost only one line of code (`$this->content = $content;`) so we have proper double writes and a trivial revert path. Test Plan: - Without migrating, added comments and saw them show up. - Migrated. - Saw all the old comments, and no damage to the new ones. - Added new comments. - Used comment preview. - Updated a revision to implicitly create an update comment and verified it looked OK. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2222 Differential Revision: https://secure.phabricator.com/D8196
71 lines
1.9 KiB
PHP
71 lines
1.9 KiB
PHP
<?php
|
|
|
|
$conn_w = id(new DifferentialRevision())->establishConnection('w');
|
|
$rows = new LiskRawMigrationIterator($conn_w, 'differential_comment');
|
|
|
|
$content_source = PhabricatorContentSource::newForSource(
|
|
PhabricatorContentSource::SOURCE_LEGACY,
|
|
array())->serialize();
|
|
|
|
echo "Migrating Differential comment text to modern storage...\n";
|
|
foreach ($rows as $row) {
|
|
$id = $row['id'];
|
|
echo "Migrating Differential comment {$id}...\n";
|
|
if (!strlen($row['content'])) {
|
|
echo "Comment has no text, continuing.\n";
|
|
continue;
|
|
}
|
|
|
|
$revision = id(new DifferentialRevision())->load($row['revisionID']);
|
|
if (!$revision) {
|
|
echo "Comment has no valid revision, continuing.\n";
|
|
continue;
|
|
}
|
|
|
|
$revision_phid = $revision->getPHID();
|
|
|
|
$dst_table = 'differential_inline_comment';
|
|
|
|
$xaction_phid = PhabricatorPHID::generateNewPHID(
|
|
PhabricatorApplicationTransactionPHIDTypeTransaction::TYPECONST,
|
|
DifferentialPHIDTypeRevision::TYPECONST);
|
|
|
|
$comment_phid = PhabricatorPHID::generateNewPHID(
|
|
PhabricatorPHIDConstants::PHID_TYPE_XCMT,
|
|
DifferentialPHIDTypeRevision::TYPECONST);
|
|
|
|
queryfx(
|
|
$conn_w,
|
|
'INSERT IGNORE INTO %T
|
|
(phid, transactionPHID, authorPHID, viewPolicy, editPolicy,
|
|
commentVersion, content, contentSource, isDeleted,
|
|
dateCreated, dateModified, revisionPHID, changesetID,
|
|
legacyCommentID)
|
|
VALUES (%s, %s, %s, %s, %s,
|
|
%d, %s, %s, %d,
|
|
%d, %d, %s, %nd,
|
|
%d)',
|
|
'differential_transaction_comment',
|
|
|
|
// phid, transactionPHID, authorPHID, viewPolicy, editPolicy
|
|
$comment_phid,
|
|
$xaction_phid,
|
|
$row['authorPHID'],
|
|
'public',
|
|
$row['authorPHID'],
|
|
|
|
// commentVersion, content, contentSource, isDeleted
|
|
1,
|
|
$row['content'],
|
|
$content_source,
|
|
0,
|
|
|
|
// dateCreated, dateModified, revisionPHID, changesetID, legacyCommentID
|
|
$row['dateCreated'],
|
|
$row['dateModified'],
|
|
$revision_phid,
|
|
null,
|
|
$row['id']);
|
|
}
|
|
|
|
echo "Done.\n";
|