mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-04 12:42:43 +01:00
8640ab5fc3
Summary: Fixes T12035. Normally, the "abc" -> "abc/" redirect is handled automatically when "abc" hits a 404. However, in this case, "source/x" does not 404. We route this to a valid controller because some VCS requests omit the slashes, then manually perform the redirect if we aren't serving a VCS request. Allow this controller to serve public resources so we can serve the redirect to logged-out users instead of prompting them to login so they can be redirected. Test Plan: Visited `/source/x` as a logged-out user, where `x` is a public repository. Reviewers: chad Reviewed By: chad Maniphest Tasks: T12035 Differential Revision: https://secure.phabricator.com/D17097
34 lines
1.2 KiB
PHP
34 lines
1.2 KiB
PHP
<?php
|
|
|
|
final class DiffusionRepositoryDefaultController extends DiffusionController {
|
|
|
|
public function shouldAllowPublic() {
|
|
// NOTE: We allow public access to this controller because it handles
|
|
// redirecting paths that are missing a trailing "/". We need to manually
|
|
// redirect these instead of relying on the automatic redirect because
|
|
// some VCS requests may omit the slashes. See T12035, and below, for some
|
|
// discussion.
|
|
return true;
|
|
}
|
|
|
|
public function handleRequest(AphrontRequest $request) {
|
|
$response = $this->loadDiffusionContext();
|
|
if ($response) {
|
|
return $response;
|
|
}
|
|
|
|
// NOTE: This controller is just here to make sure we call
|
|
// willBeginExecution() on any /diffusion/X/ URI, so we can intercept
|
|
// `git`, `hg` and `svn` HTTP protocol requests.
|
|
|
|
// If we made it here, it's probably because the user copy-pasted a
|
|
// clone URI with "/anything.git" at the end into their web browser.
|
|
// Send them to the canonical repository URI.
|
|
|
|
$drequest = $this->getDiffusionRequest();
|
|
$repository = $drequest->getRepository();
|
|
|
|
return id(new AphrontRedirectResponse())
|
|
->setURI($repository->getURI());
|
|
}
|
|
}
|