1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src/infrastructure/daemon
epriestley b9788fed00 Recover more cleanly from worker tasks with unconstructable classes
Summary:
This is unusual, but if `getWorkerInstance()` throws we end up with an undefined `$worker` when recovering from the exception.

Instead, handle this case slightly more gracefully.

The easiest way to hit this is to schedule a task for a worker that doesn't exist (or remove an existing worker, which is what I did to hit it).

Test Plan: Saw a more graceful error recovery; ran some normal successful tasks out of the queue.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11413
2015-01-15 15:57:02 -08:00
..
bot Fix the visibility of PhutilDaemon::run methods 2015-01-16 06:59:29 +11:00
control Allow daemons to be terminated in the absence of MySQL 2015-01-15 06:56:38 +11:00
garbagecollector Fix the visibility of PhutilDaemon::run methods 2015-01-16 06:59:29 +11:00
workers Recover more cleanly from worker tasks with unconstructable classes 2015-01-15 15:57:02 -08:00
PhabricatorDaemon.php Add "phd.user" with sudo hooks for SSH/HTTP writes 2013-11-18 08:58:35 -08:00