1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-03-13 04:44:53 +01:00
phorge-phorge/src/applications/files/xaction
Andre Klapper c3850a3c15 Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/xaction/PhabricatorFileAltTextTransaction.php:59]
```

Closes T15678

Test Plan: Add and remove alt text on an image file; then go to `/feed/query/all/`

Reviewers: O1 Blessed Committers, speck

Reviewed By: O1 Blessed Committers, speck

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15678

Differential Revision: https://we.phorge.it/D25481
2023-11-28 14:52:00 +01:00
..
PhabricatorFileAltTextTransaction.php Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file 2023-11-28 14:52:00 +01:00
PhabricatorFileDeleteTransaction.php Switch File deletion to use ModularTransactions 2017-04-18 13:01:51 -07:00
PhabricatorFileNameTransaction.php Move Files to ModularTransactions 2017-04-04 10:25:05 -07:00
PhabricatorFileTransactionType.php Move Files to ModularTransactions 2017-04-04 10:25:05 -07:00