1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 03:02:43 +01:00
phorge-phorge/src/applications/owners
epriestley 5aae89babb Fix file PHID extraction in Owners and Differential
Summary:
Ref T9787. To fix this, I want to change how file PHIDs are extracted slightly: specifically, I'm going to extract them later in the editing process.

Before doing this, clean up a couple of bad implementations:

  - Owners extracts its description as a file PHID. This is an error.
    - Extract the description as a remarkup block instead.
    - Add an edge table so stuff like file attachment works properly.
  - Differential has a no-op extract method. This is presumably just a copy/paste issue from long ago.

Test Plan:
  - Edited a revision in Differential.
  - Dropped a file into the description of an Owners package.
    - Before change: this did not attach the file.
    - After change: the file now attaches properly and shows up as "Attached" in the file details.

Reviewers: chad, joshuaspence

Reviewed By: joshuaspence

Subscribers: joshuaspence

Maniphest Tasks: T9787

Differential Revision: https://secure.phabricator.com/D14493
2015-11-17 08:36:50 -08:00
..
application Update Owners docs a bit 2015-08-31 16:01:01 -07:00
conduit Further modernize OwnersPackageQuery 2015-08-17 10:09:17 -07:00
config Add CustomField support to Owners 2015-09-10 13:32:31 -07:00
controller Fix button for "All Problem Commits" on Owners packages 2015-09-29 06:43:55 -07:00
customfield Add CustomField support to Owners 2015-09-10 13:32:31 -07:00
editor Fix file PHID extraction in Owners and Differential 2015-11-17 08:36:50 -08:00
mail Build separate mail for each recipient, honoring recipient access levels 2015-06-03 18:59:31 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Fix an issue where paths could bleed across repos in Owners 2015-09-01 08:07:06 -07:00
searchfield Move some PhabricatorSearchField subclasses 2015-07-06 22:52:05 +10:00
storage Fix file PHID extraction in Owners and Differential 2015-11-17 08:36:50 -08:00
typeahead Fix an issue with "packages(...)" in typeaheads 2015-09-01 15:35:25 -07:00