1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 18:52:42 +01:00
phorge-phorge/src/applications/people
epriestley ba83380565 Update the "Notification Test" workflow to use more modern mechanisms
Summary:
Depends on D19860. Ref T13222. Ref T10743. See PHI996.

Long ago, there were different types of feed stories. Over time, there was less and less need for this, and nowadays basically everything is a "transaction" feed story. Each story renders differently, but they're fundamentally all about transactions.

The Notification test controller still uses a custom type of feed story to send notifications. Move away from this, and apply a transaction against the user instead. This has the same ultimate effect, but involves less weird custom code from ages long forgotten.

This doesn't fix the actual problem with these things showing up in feed. Currently, stories always use the same rendering for feed and notifications, and there need to be some additional changes to fix this. So no behavioral change yet, just slightly more reasonable code.

Test Plan: Clicked the button and got some test notifications, with Aphlict running.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13222, T10743

Differential Revision: https://secure.phabricator.com/D19861
2018-12-10 16:02:11 -08:00
..
application Add a "Can Disable Users" capability to the "People" application 2018-08-27 08:01:27 -07:00
cache Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
capability Add a "Can Disable Users" capability to the "People" application 2018-08-27 08:01:27 -07:00
conduit Deprecate "user.enable" and "user.disable" API methods, redefine them in terms of "user.edit" 2018-08-27 08:00:48 -07:00
config Move "wild" config types to new code 2017-06-27 12:34:56 -07:00
controller Update the "Notification Test" workflow to use more modern mechanisms 2018-12-10 16:02:11 -08:00
customfield Add a modern "user.edit" API method for users 2018-08-16 10:48:38 -07:00
editor Update the "Notification Test" workflow to use more modern mechanisms 2018-12-10 16:02:11 -08:00
engine Add Revisions to User Profiles 2017-05-21 09:24:37 -07:00
engineextension Add an "availaiblity" attachment for user.search 2018-12-09 16:41:12 -08:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
guidance Add a bunch of Phacility-specific code to the upstream, thinly veiled as generic code 2016-11-15 09:11:22 -08:00
icon Add additional icons for User Profiles 2016-01-31 20:09:06 +00:00
lipsum Make bin/lipsum generate hanldle generator keys and arguments more clearly 2017-02-27 09:09:28 -08:00
management Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
markup Fix spelling 2017-10-09 10:48:04 -07:00
menuitem Add Revisions to User Profiles 2017-05-21 09:24:37 -07:00
phid Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention 2018-02-06 04:04:52 -08:00
policyrule Move some files around 2015-11-17 06:26:13 +11:00
query Continue cleaning up queries in the wake of changes to "%Q" 2018-11-16 12:49:44 -08:00
search Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
searchfield Add basic typechecking support to Conduit 2015-12-14 04:21:39 -08:00
storage Add an "availaiblity" attachment for user.search 2018-12-09 16:41:12 -08:00
typeahead Separate sever-side typeahead queries into "prefix" and "content" phases 2016-11-10 08:54:59 -08:00
view Make the remote address rules for Settings > Activity Logs more consistent 2018-01-30 15:45:39 -08:00
xaction Update the "Notification Test" workflow to use more modern mechanisms 2018-12-10 16:02:11 -08:00