1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 17:22:42 +01:00
phorge-phorge/src/applications/auth/exception
epriestley 29b4fad941 Get rid of "throwResult()" for control flow in MFA factors
Summary: Depends on D20034. Ref T13222. This is just cleanup -- I thought we'd have like two of these, but we ended up having a whole lot in Duo and a decent number in SMS. Just let factors return a result explicitly if they can make a decision early. I think using `instanceof` for control flow is a lesser evil than using `catch`, on the balance.

Test Plan: `grep`, went through enroll/gate flows on SMS and Duo.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13222

Differential Revision: https://secure.phabricator.com/D20035
2019-01-28 09:40:28 -08:00
..
PhabricatorAuthHighSecurityRequiredException.php Improve UI messaging around "one-shot" vs "session upgrade" MFA 2018-12-28 00:11:36 -08:00
PhabricatorAuthInviteAccountException.php Add email invites to Phabricator (logic only) 2015-02-09 16:12:36 -08:00
PhabricatorAuthInviteDialogException.php Add email invites to Phabricator (logic only) 2015-02-09 16:12:36 -08:00
PhabricatorAuthInviteException.php Add email invites to Phabricator (logic only) 2015-02-09 16:12:36 -08:00
PhabricatorAuthInviteInvalidException.php Add email invites to Phabricator (logic only) 2015-02-09 16:12:36 -08:00
PhabricatorAuthInviteLoginException.php Add email invites to Phabricator (logic only) 2015-02-09 16:12:36 -08:00
PhabricatorAuthInviteRegisteredException.php Add email invites to Phabricator (logic only) 2015-02-09 16:12:36 -08:00
PhabricatorAuthInviteVerifyException.php Add email invites to Phabricator (logic only) 2015-02-09 16:12:36 -08:00