1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
phorge-phorge/webroot/rsrc/js/application/differential
epriestley 7d0d6fbcf2 Consolidate changeset rendering logic
Summary:
Ref T5179. Currently, all the changeset rendering logic is in the "populate" behavior, and a lot of it comes in via configuration and is hard to get at.

Instead, surface an object which can control it, and which other behaviors can access more easily.

In particular, this allows us to add a "Load/Reload" item to the view options menu, which would previously have been very challenging.

Load/Reload isn't useful on its own, but is a step away from "Show whitespace as...", "Highlight as...", "Show tabtops as...", "View Unified", "View Side-By-Side", etc.

Test Plan:
  - Viewed Differential.
  - Viewed Diffusion.
  - Viewed large changesets, clicked "Load".
  - Used "Load" and "Reload" from view options menu.
  - Loaded all changes in a large diff, verified "Load" and TOC clicks take precedence over other content loads.
  - Played with content stability stuff.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5179

Differential Revision: https://secure.phabricator.com/D9286
2014-06-03 18:01:18 -07:00
..
behavior-add-reviewers-and-ccs.js Various linter fixes. 2014-02-26 12:44:58 -08:00
behavior-comment-jump.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-comment-preview.js Use JsShrink if jsxmin is not available 2013-05-18 17:04:22 -07:00
behavior-diff-radios.js Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
behavior-dropdown-menus.js Consolidate changeset rendering logic 2014-06-03 18:01:18 -07:00
behavior-edit-inline-comments.js Various linter fixes. 2014-02-26 12:44:58 -08:00
behavior-keyboard-nav.js Various linter fixes. 2014-02-26 12:44:58 -08:00
behavior-populate.js Consolidate changeset rendering logic 2014-06-03 18:01:18 -07:00
behavior-show-all-comments.js Hide seen transactions by default in all modern applications 2014-02-14 10:23:07 -08:00
behavior-show-field-details.js Further improve unit/lint rendering 2012-05-01 10:15:56 -07:00
behavior-show-more.js Don't mangle inline comments with tables in them in Differential 2013-09-10 15:31:32 -07:00
behavior-toggle-files.js Better JS for Differential File Collapsing Undo 2013-08-13 16:14:26 -07:00
behavior-user-select.js Enable selecting text in Differential shield and gap 2012-09-20 15:20:47 -07:00
ChangesetViewManager.js Consolidate changeset rendering logic 2014-06-03 18:01:18 -07:00
DifferentialInlineCommentEditor.js Don't mangle inline comments with tables in them in Differential 2013-09-10 15:31:32 -07:00