epriestley 72f149bf39 Require rows passed to "loadAllFromArray()" have unique keys ... Summary: See PHI1809, which identified a bug in Project search where queries with a large number of slugs could paginate improperly. This change detects problems in this category: cases where multiple rows with the same ID are passed to "loadAllFromArray()". It's likely that all cases it detects are cases where a GROUP BY is missing. Since this might have some false positives or detect some things which aren't fundamentally problematic, I'm planning to hold it until the next release. Test Plan: - Reverted D21399, then created a project with multiple slugs and queried for one of them via "project.search". Hit this new exeception. - Browsed around a bit, didn't immediately catch any collateral damage. Differential Revision: https://secure.phabricator.com/D21400		2020-08-12 09:05:14 -07:00
..
__tests__	Update PhabricatorLiskDAO::chunkSQL() for new %Q semantics	2018-11-13 08:59:18 -08:00
connection	Use the "@" operator to silence connection retry messages if initializing the stack with database config optional	2019-09-03 12:54:17 -07:00
exception	Move web application classes into "phabricator/"	2019-09-02 07:58:59 -07:00
future	Move web application classes into "phabricator/"	2019-09-02 07:58:59 -07:00
lisk	Require rows passed to "loadAllFromArray()" have unique keys	2020-08-12 09:05:14 -07:00
management	Make "bin/storage destroy" target individual hosts in database cluster mode	2019-09-04 10:11:08 -07:00
patch	Rename "pastebin" database to "paste"	2019-07-19 05:53:26 -07:00
schema	When storage is partitioned, refuse to serve requests unless web and databases agree on partitioning	2016-11-22 04:15:46 -08:00
xsprintf	Move web application classes into "phabricator/"	2019-09-02 07:58:59 -07:00