1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src
epriestley bc5598865f Fix a stray comma on File previews
Summary:
There's a comma to the lower-left of my profile picture here:

{F248962}

This is on a page like https://secure.phabricator.com/F248948

What's happening is that some `render()` method is returning a valid result like `array($stuff, null)`. This is getting passed to JS as an array, which is implicitly `join()`'ing it into a string, adding a comma.

Instead, make sure we render these to strings on the server side before shipping them to the client.

Test Plan: No more comma on file previews.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D10974
2014-12-11 11:10:52 -08:00
..
__tests__ Remove UTF8 BMP unit test and replace it with a general UTF8 test 2014-10-02 11:47:25 -07:00
aphront Make ConduitCall always local/in-process 2014-12-10 15:27:07 -08:00
applications Fix a stray comma on File previews 2014-12-11 11:10:52 -08:00
docs Fixed typo in Phame user guide 2014-11-26 05:07:43 -08:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure When a worker task fails permanently, log the reason 2014-12-08 11:27:10 -08:00
view Transactions - make quotes work for older transactions 2014-12-11 10:27:28 -08:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php Maniphest - use subscribers framework properly 2014-12-10 16:27:30 -08:00