1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
phorge-phorge/src/view
Andre Klapper bccd4f5981 Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Dashboard page
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15295

Test Plan: Applied these four changes (on top of D25144 and D25145) and `/dashboard/` finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15295

Differential Revision: https://we.phorge.it/D25146
2023-05-01 15:45:24 +02:00
..
__tests__ Fix local time test case for logged-out viewers using global settings 2016-11-28 09:27:11 -08:00
control Fix numerous PHP 8.1 "strlen(null)" exceptions trying access Configuration page 2023-04-29 14:39:40 +02:00
extension Introduce "Curtain" views, panels, and extensions 2016-03-06 09:27:55 -08:00
form Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Dashboard page 2023-05-01 15:45:24 +02:00
formation Stick the page footer in the right place on Formation View pages 2020-04-24 11:25:31 -07:00
fuel Improve handle/status list display on devices in commit graph lists 2020-08-12 09:04:08 -07:00
layout Fix numerous PHP 8.1 "strlen(null)" exceptions which block rendering the Applications page 2023-05-01 15:34:32 +02:00
page Fix numerous PHP 8.1 "strlen(null)" exceptions preventing homepage to display 2023-04-27 14:08:48 +02:00
phui Fix PHP 8.1 "strlen(null)" exceptions which block rendering the Dashboard page 2023-05-01 15:45:24 +02:00
widget Merge a small amount of remaining "libphutil/" code with Phabricator, break libphutil dependency 2020-02-12 15:17:36 -08:00
AphrontAutoIDView.php Add a "FormationView" to support dynamic flank panels 2020-04-22 08:23:21 -07:00
AphrontDialogView.php Members page of Parent Subproject: less dead-end 2023-04-25 20:53:44 +02:00
AphrontJavelinView.php Various linter fixes 2015-05-20 07:27:41 +10:00
AphrontNullView.php Provide hasChildren() to replace isEmptyContent() 2013-08-12 07:51:01 -07:00
AphrontTagView.php Remove extra container tag on HandleListViews rendering from ModularTransactions in text mode 2017-01-09 08:41:59 -08:00
AphrontView.php Fix spelling 2017-10-09 10:48:04 -07:00
viewutils.php When printing timestamps on paper: use an absolute, context-free date format 2020-09-04 16:36:34 -07:00