epriestley 996930da2a Improve several exception behaviors for Harbormaster workers ... Summary: Ref T2015. Several fixes: - `checkForCancellation()` no longer exists, and isn't relevant for resumable stops. Throw it away for now. - Fix an issue where a build could pass even if the final step failed. - `phlog()` exceptions so they show up in `bin/harbormaster` and the daemon logs. - Write an exception log if a step fails. - Add a "throw an exception" step to debug this stuff more easily. Test Plan: - Grepped for `checkForCancellation()`. - Ran a failing build where the final step caused the failure. - Observed `phlog()` in `bin/harbormaster` output. - Observed log in web UI: {F101168} Reviewers: btrahan, hach-que Reviewed By: btrahan CC: aran Maniphest Tasks: T2015 Differential Revision: https://secure.phabricator.com/D7935		2014-01-13 12:21:49 -08:00
..
HarbormasterBuildWorker.php	Split Harbormaster workers apart so build steps can run in parallel	2014-01-06 12:32:10 -08:00
HarbormasterTargetWorker.php	Improve several exception behaviors for Harbormaster workers	2014-01-13 12:21:49 -08:00
HarbormasterWorker.php	Split Harbormaster workers apart so build steps can run in parallel	2014-01-06 12:32:10 -08:00