1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 01:32:42 +01:00
phorge-phorge/src/applications
elynde bd0a4c0d04 Differential Updates View
Summary:
This adds a new view to differential called Updates.

The high-level goal of Updates is to enabled differential to be
effectively used without email notifications. I've tried doing things
like automatically deleting differential emails where I'm in the 'to'
line since they show up on the main diffential page but then there's
always the chance an important diff flies by without me seeing it. Also,
sometimes someone comments on a diff post-commit but differential
doesn't surface those diffs.

I re-created a test db on my devserver using mysqldump to get data on
revs > 230000 so I would have some test data. We need to add a simple
viewtime table but I didn't want to do that in production. Here's the
table:

  CREATE TABLE differential_viewtime (
    viewerPHID varchar(64) not null,
    objectPHID varchar(64) not null,
    viewTime int unsigned not null,
    PRIMARY KEY (viewerPHID, objectPHID)
  );

Issues:
  -Once we turn this on, all diffs will be 'unviewed'. What do you think
about a 'Clear All' button or something?
  -Maybe we should add a pager

This feature would be insanely useful, let me know what you think.

Test Plan:
Loaded Updates in my sandbox

  http://phabricator.dev1577.snc6.facebook.com/differential/filter/updates/

Clicked a diff, then went back, made sure diff disappeared from Updates
list

Reviewed By: tuomaspelkonen
Reviewers: epriestley, jungejason, tuomaspelkonen
Commenters: epriestley
CC: epriestley, elynde, tuomaspelkonen
Differential Revision: 169
2011-04-28 14:40:41 -07:00
..
auth Don't reveal oauth application token information 2011-04-14 13:32:49 -07:00
base Automatically redirect 404's that wouldn't be 404s if they had a trailing slash 2011-04-04 10:29:46 -07:00
conduit Added commit information to 'getrevision' conduit call. 2011-04-25 15:32:33 -07:00
daemon/controller Prevent a race in Phabricator workers 2011-04-14 12:09:56 -07:00
differential Differential Updates View 2011-04-28 14:40:41 -07:00
diffusion Display file name in <title> for easier browsing of code 2011-04-21 17:22:47 -07:00
directory Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
draft/storage Revision comment drafts. 2011-02-05 16:57:21 -08:00
files Image macros for Phabricator! 2011-04-13 20:08:13 -07:00
herald Added a link to the actual object in Herald transcript. 2011-04-12 11:35:26 -07:00
maniphest Removed extra space from Maniphest email subject line. 2011-04-11 12:47:10 -07:00
metamta Fix 'Transcript' links in Differential 2011-04-08 01:10:05 -07:00
owners Removing reordering code that wasn't needed 2011-04-20 17:07:46 -07:00
people Fix systemAgent stuff. 2011-04-12 19:00:54 -07:00
phid Added commit information to 'getrevision' conduit call. 2011-04-25 15:32:33 -07:00
preferences/controller Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
project Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
repository Allow GitCommitChangeParser to parse 'T' (type change) messages in 2011-04-14 14:16:53 -07:00
search Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
status/base Add /status/ 2011-04-08 11:13:51 -07:00
typeahead/controller Basic create_user script plus rough system agent support. 2011-04-12 18:34:53 -07:00
uiexample Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
xhpastview Add missing includes from XHPAST parse bug. 2011-04-06 23:14:58 -07:00
xhprof Lint fluff. 2011-02-06 12:58:01 -08:00