1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src
epriestley bdda7eed07 Improve display behavior for write locks held by omnipotent users
Summary:
Ref T13614. When an omnipotent user calls "synchronizeWorkingCopyBeforeWrite()", we record a WorkingCopyVersion record with a null "userPHID". The UI then renders this as "Unknown Object (????)".

Improve this behavior:

  - When no PHID is available, just render nothing in the UI (this doesn't seem meaningfully different from no version existing at all).
  - Allow callers to provide an acting user PHID, similar to Editor.

There's currently no way to perform this kind of write legitimately in the upstream, but T13614 is providing one.

Test Plan:
  - Wrote a script that calls "synchronizeWorkingCopyBeforeWrite()" as the omnipotent user.
  - Ran script, saw "Unknown Object (????)" in the UI.
  - Applied UI fix, saw empty UI.
  - Applied "acting as" fix, modified script to act as the Diffusion application, ran script, saw "Diffusion" attribution in UI.

{F8814806}

Maniphest Tasks: T13614

Differential Revision: https://secure.phabricator.com/D21669
2021-06-01 08:29:53 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Improve routing of "/robots.txt", "/favicon.ico", "/status/", and 404 on custom Sites 2021-03-11 14:05:39 -08:00
applications Improve display behavior for write locks held by omnipotent users 2021-06-01 08:29:53 -07:00
docs Remove documentation for support, feature requests, contributing code, and filing bug reports 2021-05-29 14:10:07 -07:00
extensions
infrastructure Update client logic for inline comment "Save" and "Cancel" actions 2021-03-29 09:00:27 -07:00
view Replace Differential "unit stars" with icons 2021-03-17 13:45:52 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Replace Differential "unit stars" with icons 2021-03-17 13:45:52 -07:00