1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 03:02:43 +01:00
phorge-phorge/src/applications/diffusion/query
epriestley be235301d0 When commits have a "rewritten" hint, try to show that in handles in other applications
Summary:
Ref T11522. This tries to reduce the cost of rewriting a repository by making handles smarter about rewritten commits.

When a handle references an unreachable commit, try to load a rewrite hint for the commit. If we find one, change the handle name to "OldHash > NewHash" to provide a strong hint that the commit was rewritten and that copy/pasting the old hash (say, to the CLI) won't work.

I think this notation isn't totally self-evident, but users can click it to see the big error message on the page, and it's at least obvious that something weird is going on, which I think is the important part.

Some possible future work:

  - Not sure this ("Recycling Symbol") is the best symbol? Seems sort of reasonable but mabye there's a better one.
  - Putting this information directly on the hovercard could help explain what this means.

Test Plan: {F1780719}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11522

Differential Revision: https://secure.phabricator.com/D16437
2016-08-24 09:35:19 -07:00
..
blame Use a path digest when building blame cache keys 2016-01-06 19:12:57 -08:00
filecontent Allow diffusion.filecontentquery to load data for arbitrarily large files 2016-01-21 09:52:43 -08:00
lowlevel Ignore unrecognized refs in "refs/remotes/" 2016-06-16 16:03:36 -07:00
pathchange Extend from Phobject 2015-06-15 18:02:27 +10:00
pathid Fix a few more undeclared properties 2015-06-15 19:39:04 +10:00
rawdiff Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
DiffusionCachedResolveRefsQuery.php phtize all the things 2015-05-22 21:16:39 +10:00
DiffusionCommitHintQuery.php When commits have a "rewritten" hint, try to show that in handles in other applications 2016-08-24 09:35:19 -07:00
DiffusionCommitQuery.php Fix resolution of commits in SVN repositories without callsigns 2016-04-04 09:44:36 -07:00
DiffusionDiffInlineCommentQuery.php Extend TransactionCommentQuery for Diffusion 2015-03-09 14:11:22 -07:00
DiffusionLintCountQuery.php Use PhutilInvalidStateException 2015-05-14 07:53:52 +10:00
DiffusionPathQuery.php Extend from Phobject 2015-06-15 18:02:27 +10:00
DiffusionQuery.php Move various other callsites away from callsigns 2016-01-04 06:54:42 -08:00
DiffusionRenameHistoryQuery.php Extend from Phobject 2015-06-15 18:02:27 +10:00
DiffusionResolveUserQuery.php Provide a standalone query for resolution of commit author/committer into Phabricator users 2013-12-19 11:05:17 -08:00
DiffusionSymbolQuery.php Only link symbols if there might be any 2015-05-21 08:25:35 -07:00