1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
phorge-phorge/src/applications/herald
epriestley 8934dee543 Add "does not match regexp" to Herald
Summary:
Fixes T10330.

  - Anywhere we support "matches regexp", also allow "does not match regexp". Although you can sometimes write a clever negative regexp, these rules are better expressed with "does not match <simple regexp>" anyway, and sometimes no regexp will work.
  - Always allow "does not contain" when we support "contains".
  - Fix some JS issues with certain rules affecting custom fields.

Test Plan:
  - Wrote an "Affected files do not match regexp" rule that required every diff to touch "MANUALCHANGELOG.md".
  - Tried to diff without the file; rejected.
  - Tried to diff with the file; accepted.
  - Wrote a bunch of "contains" and "does not contain" rules against text fields and custom fields, then edited tasks to trigger/observe them.
  - Swapped the editor into custom text, user, remarkup, etc fields, no more JS errors.

{F1105172}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10330

Differential Revision: https://secure.phabricator.com/D15254
2016-02-11 15:29:38 -08:00
..
action Allow "Assign task" Herald Action in Maniphest to accept "None" to unassign 2015-12-05 12:39:45 -08:00
adapter Add "does not match regexp" to Herald 2016-02-11 15:29:38 -08:00
application Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
config Extend from Phobject 2015-06-15 18:02:27 +10:00
controller Add more NUX states 2015-12-21 11:15:54 -08:00
editor Modularize mail tags 2014-08-12 12:28:41 -07:00
engine Extend from Phobject 2015-06-15 18:02:27 +10:00
engineextension Fully modularize DestructionEngine 2015-12-21 17:03:44 -08:00
field Add "does not match regexp" to Herald 2016-02-11 15:29:38 -08:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
group Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
phid Add PHIDType for HeraldTransaction 2016-01-15 16:40:48 +00:00
query Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
storage Allow any user to watch any project they can see 2016-01-19 19:38:30 -08:00
value Improve rendering of tokenizer tokens in Herald when editing rules 2015-12-05 11:20:07 -08:00