mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-02 03:32:42 +01:00
bf2f3991d2
Summary: Depends on D20518. Ref T13283. When you use the "Test Console" in Herald to test rules, pass the most recent group of transactions to the Adapter. This will make it easier to test rules that depend on edit state, since you can make the type of edit you're trying to test and then use the Test Console to actually test if it matches in the way you expect. The transactions we select may not be exactly the group of transactions that most recently applied. For example, if you make edits A, B, and C in rapid succession and then run the Test Console on the object, it may select "A + B + C" as a transaction group. But we'll show you what we selected and this is basically sane/reasonable and should be fine. (Eventually, we could include a separate "transaction group ID" on transactions if we want to get this selection to match exactly.) Test Plan: Ran the Test Console on various objects, saw sensible transaction lists in the transcripts. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13283 Differential Revision: https://secure.phabricator.com/D20519 |
||
|---|---|---|
| .. | ||
| HeraldController.php | ||
| HeraldDisableController.php | ||
| HeraldNewController.php | ||
| HeraldRuleController.php | ||
| HeraldRuleListController.php | ||
| HeraldRuleViewController.php | ||
| HeraldTestConsoleController.php | ||
| HeraldTranscriptController.php | ||
| HeraldTranscriptListController.php | ||
| HeraldWebhookController.php | ||
| HeraldWebhookEditController.php | ||
| HeraldWebhookKeyController.php | ||
| HeraldWebhookListController.php | ||
| HeraldWebhookTestController.php | ||
| HeraldWebhookViewController.php | ||