1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-01 09:28:22 +01:00
phorge-phorge/src/applications/herald
epriestley d60d4e6a05 Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them
Summary:
Fixes T7961. Currently, we present Herald users with actions like "Require legalpad signatures" and "Run build plans" even if Legalpad and Harbormaster are not installed.

Instead, allow fields and actions to be made "unavailable", which means that we won't present them as options when adding to new or existing rules.

If you edit a rule which already uses one of these fields or actions, it isn't affected.

Test Plan:
  - Created a rule with a legalpad action, uninstalled legalpad, edited the rule. Action remained untouched.
  - Created a new rule, wasn't offered the legalpad action.
  - Reinstalled the application, saw the action again.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T7961

Differential Revision: https://secure.phabricator.com/D20808
2019-09-12 14:33:28 -07:00
..
action Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them 2019-09-12 14:33:28 -07:00
adapter Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them 2019-09-12 14:33:28 -07:00
application Document how webhooks work 2018-02-09 13:57:19 -08:00
capability Add skeleton code for webhooks 2018-02-09 13:55:04 -08:00
config Remove "HeraldRepetitionPolicyConfig" and hide storage details inside HeraldRule 2018-01-26 11:03:29 -08:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them 2019-09-12 14:33:28 -07:00
edge On Harbormaster build plans, show which Herald rules trigger builds 2019-03-07 13:51:40 -08:00
editor On Harbormaster build plans, show which Herald rules trigger builds 2019-03-07 13:51:40 -08:00
engine Add a basic profiler to Herald transcripts 2019-06-05 08:50:41 -07:00
engineextension Index Herald fields, not just actions, when identifying objects related to a particular Herald rule 2019-09-09 12:50:43 -07:00
field Don't present users with Herald fields/actions for uninstalled applications, unless the rule already uses them 2019-09-12 14:33:28 -07:00
garbagecollector Refine core webhook implementation somewhat 2018-02-09 13:55:55 -08:00
group Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
mail Support Herald rules for Herald rules 2018-04-25 06:47:19 -07:00
management Add "bin/herald rule ..." to modify Herald rules from the CLI 2019-06-04 07:12:15 -07:00
phid Trigger all "Firehose" webhooks on all transactional edits 2018-02-09 13:56:34 -08:00
query In Herald, save applied transaction PHIDs in the transcript and display them in the UI 2019-05-16 09:58:16 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
state Prepare TransactionEditor for silent transactions via bulk edit 2018-01-19 13:23:38 -08:00
storage Improve rendering of Herald rules in "Another Herald rule..." field 2019-09-09 13:29:49 -07:00
typeahead Support querying Herald rules by monogram in typeahead datsources 2018-08-01 17:52:27 -07:00
value Respect token limits for "Assign to" and custom datasource fields in Herald 2018-01-22 11:54:12 -08:00
view On Harbormaster build plans, show which Herald rules trigger builds 2019-03-07 13:51:40 -08:00
worker In Webhooks, give errors human-readable labels and show reminder text for "Silent Mode" 2018-12-28 00:05:46 -08:00
xaction Modularize PhabricatorEditEngineConfigurationTransaction 2019-06-20 16:25:21 -07:00