1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 06:20:56 +01:00
phorge-phorge/scripts/repository
epriestley f19d5fbeae Fix existence test in "reconcile.php"
Summary:
"rev-parse --verify" is actually a terrible test, it only survived my test cases
because I put garbage into the tables with RAND() or similar, not
properly-formatted garbage.

Use "cat-file -t" instead to ensure we perform an object-existence test.

Test Plan: Ran "reconcile.php P" locally, ran "cat-file -t" and "rev-parse
--verify" on properly-formatted but invalid hashes like
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", worked with @rguerin to resolve
commit issues.

Reviewers: btrahan, rguerin

Reviewed By: rguerin

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1590
2012-02-07 10:46:26 -08:00
..
parse_one_commit.php Refactor repository reparse scripts to be more useful 2011-09-27 17:20:04 -07:00
rebuild_summaries.php Merge __init_env__.php into __init_script__.php 2011-10-02 11:48:09 -07:00
reconcile.php Fix existence test in "reconcile.php" 2012-02-07 10:46:26 -08:00
reparse.php Add Related Commits for Owners 2011-12-14 22:48:57 -08:00
reparse_all_commit_messages.php Refactor repository reparse scripts to be more useful 2011-09-27 17:20:04 -07:00
test_connection.php Merge __init_env__.php into __init_script__.php 2011-10-02 11:48:09 -07:00