epriestley 9f5e6bee90 Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw" ... Summary: Depends on D20115. See <https://discourse.phabricator-community.org/t/transaction-search-endpoint-does-not-work-on-differential-diffs/2369/>. Currently, `getApplicationTransactionCommentObject()` throws by default. Subclasses must override it to `return null` to indicate that they don't support comments. This is silly, and leads to a bunch of code that does a `try / catch` around it, and at least some code (here, `transaction.search`) which doesn't `try / catch` and gets the wrong behavior as a result. Just make it `return null` by default, meaning "no support for comments". Then remove the `try / catch` stuff and all the `return null` implementations. Test Plan: - Grepped for `getApplicationTransactionCommentObject()`, fixed each callsite / definition. - Called `transaction.search` on a diff with transactions (i.e., not a sourced-from-commit diff). Reviewers: amckinley Reviewed By: amckinley Subscribers: jbrownEP Differential Revision: https://secure.phabricator.com/D20121		2019-02-07 14:56:38 -08:00
..
PhabricatorOAuthClientAuthorization.php	Fix visiblity of LiskDAO::getConfiguration()	2015-01-14 06:54:13 +11:00
PhabricatorOAuthServerAccessToken.php	Make OAuth scope handling more flexible	2016-04-05 13:53:33 -07:00
PhabricatorOAuthServerAuthorizationCode.php	Fix visiblity of LiskDAO::getConfiguration()	2015-01-14 06:54:13 +11:00
PhabricatorOAuthServerClient.php	Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface	2018-12-20 15:16:19 -08:00
PhabricatorOAuthServerDAO.php	Remove @group annotations	2014-07-10 08:12:48 +10:00
PhabricatorOAuthServerTransaction.php	Make the default behavior of getApplicationTransactionCommentObject() "return null" instead of "throw"	2019-02-07 14:56:38 -08:00