1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
phorge-phorge/src
epriestley c13f9d157b Fix double-stops on profiler sampling
Summary:
For some time, we've stopped the profiler twice when it was invoked by the sampling mechanism. The first time it actually stops, and we write a profile. The second time it hadn't been started, so it returns empty and we write an invalid profile.

Instead, keep track of whether it is running or not, and don't stop it a second time.

Ref T2870.

Test Plan: Set sample rate to 1-in-3, observed valid sample profiles generate.

Reviewers: btrahan, chad

CC: aran

Maniphest Tasks: T2870

Differential Revision: https://secure.phabricator.com/D5534
2013-04-02 10:05:43 -07:00
..
aphront Fix double-stops on profiler sampling 2013-04-02 10:05:43 -07:00
applications Guarantee the existence of the Phabricator access log 2013-04-02 09:53:56 -07:00
docs Provide Sublime Text documentation hint for Arc + windows 2013-03-30 19:27:59 -07:00
infrastructure Guarantee the existence of the Phabricator access log 2013-04-02 09:53:56 -07:00
view First pass at hovercard design 2013-04-02 09:16:23 -07:00
__celerity_resource_map__.php Fix double-stops on profiler sampling 2013-04-02 10:05:43 -07:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php Fix XHProf index page 2013-04-02 09:52:52 -07:00