1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 23:32:40 +01:00
phorge-phorge/externals
epriestley 8a906b0e18 Remove skins from Phame
Summary:
Ref T9897. Purge a bunch of stuff:

  - Remove skins.
  - Remove all custom sites for skin resources.
  - Remove "framed", "notlive", "preview", separate "live" controllers (see below).
  - Merge "publish" and "unpublish" controllers into one.

New behavior:

  - Blogs and posts have three views:
    - "View": Internal view URI, which is a normal detail page.
    - "Internal Live": Internal view URI which is a little prettier.
    - "External Live": External view URI for an external domain.

Right now, the differences are pretty minor (basically, different crumbs/chrome). This mostly gives us room to put some milder flavor of skins back later (photography or more "presentation" elements, for example).

This removes 9 million lines of code so I probably missed a couple of things, but I think it's like 95% of the way there.

Test Plan:
Here are some examples of what the "view", "internal" and "external" views look like for blogs (posts are similar):

"View": Unchanged

{F1021634}

"Internal": No chrome or footer. Still write actions (edit, post commments). Has crumbs to get back into Phame.

{F1021635}

"External": No chrome or footer. No write actions. No Phabricator crumbs. No policy/status information.

{F1021638}

I figure we'll probably tweak these a bit to figure out what makes sense (like: maybe no actions on "internal, live"? and "external, live" probably needs a way to set a root "Company >" crumb?) but that they're reasonable-ish as a first cut?

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9897

Differential Revision: https://secure.phabricator.com/D14740
2015-12-11 08:14:12 -08:00
..
amazon-ses Fix undefined property in Amazon SES 2013-11-26 12:52:38 -08:00
cowsay Use PHP implementation of Cowsay for cowsay rule 2015-09-13 12:27:30 -07:00
diff_match_patch Phragment v0 2013-12-07 12:43:49 +11:00
figlet Include "Figlet" and PEAR "Text_Figlet" in externals 2015-09-13 12:30:48 -07:00
httpful Add Balanced Payments API 2013-04-25 09:47:30 -07:00
JsShrink Update JsShrink external library. 2014-06-07 11:26:20 -07:00
mimemailparser Work around mailparse bug (?) with messages that have no terminal newline 2015-04-21 09:49:40 -07:00
pear-figlet Use PEAR Text_Figlet to render figlet fonts 2015-09-13 12:31:07 -07:00
phpmailer Changed default timeout of smtp from 10s to 60s. 2014-04-24 04:59:22 -07:00
phpqrcode Quickly fix phpqrcode syntax 2015-08-31 14:05:51 -07:00
recaptcha PhabricatorEnv 2011-01-31 11:55:26 -08:00
restful Add Balanced Payments API 2013-04-25 09:47:30 -07:00
s3 Update S3 external library 2013-07-02 18:55:08 -07:00
stripe-php Update Stripe PHP API 2014-07-13 09:19:07 -07:00
twilio-php Remove some needless +x flags. 2014-05-17 15:41:12 -07:00
wepay Strip +x from some WePay files 2013-11-12 17:48:47 -08:00
wordlist Add a common password blacklist 2014-01-23 14:01:18 -08:00
xhprof Fix some issues caught by HipHop, and work around some issues 2011-02-26 21:01:42 -08:00