1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-07 05:11:05 +01:00
phorge-phorge/src/infrastructure
Andre Klapper c1a8b83bd7 Correct PHPDoc or add default return for numerous methods
Summary:
Correct PHPDoc when none of the method calls try to handle a return value.
Add missing fallback `return` statements (which may never be reached if previous condition checks were always true).

This reduces the amount of errors reported by static code analysis tools.

Test Plan: Carefully read the code and check all places in which a function gets called whether a return value is expected.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25650
2024-05-18 21:54:51 +02:00
..
cache Use "@" to silence "GC list" warnings from "apc_store()" and "apcu_store()" 2020-04-28 04:13:37 -07:00
cluster Fix PHP 8.1 strlen() error when database replication Seconds_Behind_Master is NULL 2023-06-30 13:49:32 +01:00
contentsource Fix PHP 8.1 "strlen(null)" exception which blocks creating personal and global Herald rules 2023-05-05 12:53:14 +02:00
customfield Add (Advanced) Custom Fields to Item List 2024-05-11 13:25:41 +03:00
daemon Correct PHPDoc or add default return for numerous methods 2024-05-18 21:54:51 +02:00
diff Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web interface 2023-06-02 20:40:42 +02:00
edges Correct PHPDoc or add default return for numerous methods 2024-05-18 21:54:51 +02:00
editor Fix PHP 8.1 PhabricatorEditorURIEngine::newForViewer() trim(NULL) error 2023-07-17 11:03:52 +01:00
env isSelfURI: fix anchors and relative URIs (that are "self" indeed) 2024-03-19 17:34:24 +01:00
events Change some instances of "phabricator" to "phorge" 2023-11-18 22:14:15 +00:00
export Fix exception trying to export empty task list to CSV 2024-05-02 10:29:14 +02:00
graph Render user hovercards with context information about their ability to see the context object 2021-02-13 13:37:37 -08:00
internationalization Make i18n string extraction ignore strings in test case files 2024-05-08 10:58:32 -04:00
javelin Make src/infrastructure/javelin/markup.php phabricator_form PHP 8.1 compliant 2023-06-30 15:13:20 +01:00
lint/linter Linter fixes 2015-12-03 07:44:23 +11:00
lipsum Continue moving classes with no callers in libphutil or Arcanist to Phabricator 2020-02-12 13:14:04 -08:00
log PHP 8.2: fixes for strlen() not accepting NULL anymore, part 1 2023-03-31 22:05:52 +02:00
management Add additional flags to "bin/repository rebuild-identities" to improve flexibility 2019-11-19 09:39:48 -08:00
markup PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a string 2024-04-30 09:28:20 +02:00
parser Correct spelling mistakes 2023-05-27 22:19:06 +01:00
query Fix "Map omits required key" exception by comparing result order against modern field keys 2024-03-21 19:25:50 +01:00
ssh Generate a random unique "Request ID" for SSH requests so processes can coordinate better 2018-03-22 13:44:30 -07:00
status Give Drydock Leases more modern status treatment 2018-02-13 13:15:57 -08:00
storage Fix PHP 8.1 "strlen(null)" exception for "/bin/storage renamespace" without parameter 2024-04-17 13:12:40 +02:00
syntax Improve remarkup codeblock syntax highlighting when using Dark Mode 2024-03-03 15:58:03 +01:00
testing When running unit tests, ignore any custom task fields 2017-04-02 09:36:17 -07:00
time Render timezone names more readably, with spaces rather than underscores ("America/Los Angeles", not "America/Los_Angeles"). 2019-05-30 15:03:11 -07:00
util Remove product literal strings in "pht()", part 25 2022-04-25 16:46:26 -07:00
PhabricatorEditor.php Mark some strings for translation 2015-06-09 23:06:52 +10:00