1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 11:42:42 +01:00
phorge-phorge/src/applications/harbormaster/storage
epriestley c1bff3b801 Add an "Restartable: If Failed" behavior to Harbormaster build plans
Summary:
Ref T13249. Ref T13258. In some cases, builds are not idempotent and should not be restarted casually.

If the scary part is at the very end (deploy / provision / whatever), it could be okay to restart them if they previously failed.

Also, make the "reasons why you can't restart" and "explanations of why you can't restart" logic a little more cohesive.

Test Plan:
  - Tried to restart builds in various states (failed/not failed, restartable always/if failed/never, already restarted), got appropriate errors or restarts.
  - (I'm not sure the "Autoplan" error is normally reachable, since you can't edit autoplans to configure things to let you try to restart them.)

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13258, T13249

Differential Revision: https://secure.phabricator.com/D20252
2019-03-07 16:47:57 -08:00
..
build Add an "Restartable: If Failed" behavior to Harbormaster build plans 2019-03-07 16:47:57 -08:00
configuration Add an "Restartable: If Failed" behavior to Harbormaster build plans 2019-03-07 16:47:57 -08:00
HarbormasterBuildable.php Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
HarbormasterBuildableTransaction.php [harbormaster/abort-builds] Support aborting builds in Harbormaster 2015-09-21 12:07:38 -07:00
HarbormasterBuildCommand.php [harbormaster/abort-builds] Support aborting builds in Harbormaster 2015-09-21 12:07:38 -07:00
HarbormasterBuildMessage.php Make Harbormaster objects destructible 2018-03-29 13:01:14 -07:00
HarbormasterBuildTransaction.php [harbormaster/abort-builds] Support aborting builds in Harbormaster 2015-09-21 12:07:38 -07:00
HarbormasterDAO.php Delete license headers from files 2012-11-05 11:16:51 -08:00
HarbormasterObject.php Fix visiblity of LiskDAO::getConfiguration() 2015-01-14 06:54:13 +11:00
HarbormasterSchemaSpec.php Give HarbormasterBuildLogChunk a real table 2016-03-01 15:25:34 -08:00
HarbormasterScratchTable.php Allow columns to be marked as nonmutable (so save() will not change them) 2015-02-19 10:37:17 -08:00
HarbormasterString.php Allow unit tests to have arbitrarily long names (>255 characters) 2019-02-19 11:21:42 -08:00