1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 19:32:40 +01:00
phorge-phorge/src/applications/search/engine
epriestley c21be4849f By default, do not save queries when executing Conduit "*.search" calls
Summary:
Fixes T11304. Prior to this change, we did an unnecessary write on every "*.search" call (this write didn't always actually write a row, since we only save //unique// saved queries, but still doesn't do anything useful ever, currently).

Instead, change this to not-write by default. We could add an "oh, and also I want you to do a write" option later, which would let us implement something like `arc query-stuff` which says "To see more results, view this URI in your browser: ...".

(It's possible to run one of these methods with an existing SavedQuery by using the key, so we still sometimes have a queryKey to return.)

Test Plan: Ran `almanac.service.search`, used DarkConsole to verify that no serachengine writes occurred.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11304

Differential Revision: https://secure.phabricator.com/D16263
2016-07-10 08:04:11 -07:00
..
__tests__ Rename "SearchEngine" to "FulltextStorageEngine" 2015-12-21 17:26:19 -08:00
PhabricatorApplicationSearchEngine.php By default, do not save queries when executing Conduit "*.search" calls 2016-07-10 08:04:11 -07:00
PhabricatorJumpNavHandler.php Reduce the total number of calls to getCallsign() 2016-01-02 04:23:06 -08:00
PhabricatorProfilePanelEngine.php Modernize various menu collapse settings 2016-06-04 14:44:36 -07:00
PhabricatorSearchEngineAPIMethod.php Fix typo in link to docs 2016-05-31 23:36:15 +00:00