1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 17:02:41 +01:00
phorge-phorge/src
epriestley c310f08b7a Work around workflow blocking error with duplicate "master" refs in "Land Revision"
Summary:
Ref T11823. See PHI68. T11823 has a full description of this issue and a plan to fix it, but the full plan is relatively complicated.

Until that can happen, provide a workaround for the biggest immediate issue, where multiple copies of a ref cursor can cause `executeOne()` to throw, since it expects a single result. In practice, these copies are always identical so we can just pick the first one.

This will get cleaned up once T11823 is fixed properly.

Test Plan:
Forced the table into a duplicate/ambiguous state, reproduced a similar-looking error:

{F5180999}

Applied the patch, got the "Land" to work as expected:

{F5181000}

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T11823

Differential Revision: https://secure.phabricator.com/D18599
2017-09-13 16:03:10 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Pass all Throwables to Exception Handlers, not just Exceptions 2017-06-20 05:44:51 -07:00
applications Work around workflow blocking error with duplicate "master" refs in "Land Revision" 2017-09-13 16:03:10 -07:00
docs Document Ferret engine fulltext search features 2017-09-12 12:13:23 -07:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Fix an issue with selecting the right stemmed ngrams with Ferret engine queries 2017-09-12 12:13:42 -07:00
view Update Create Diff page for new Edit UI 2017-09-06 10:14:58 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Make "mysql" mean "Ferret engine" in Fulltext search 2017-09-11 18:05:12 -07:00