1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
phorge-phorge/webroot/rsrc
epriestley c37b6c6633 When users click a symbol in Differential to jump to the definition, include path/line context
Summary:
Ref T13047. In some reasonable cases, knowing the path and line number where a symbol appears is useful in ranking or filtering the set of matching symbols.

Giving symbol sources more information can't hurt, and it's generally free for us to include this context since we just need to grab it out of the document and pass it along.

We can't always get this data (for example, if a user types `s idx` into global search, we have no clue) but this is similar to other types of context which are only available sometimes (like which repository a symbol appears in).

Test Plan: Command-clicked some symbols in 1-up (unified) and 2-up (side-by-side) diff views with symbol indexes configured. Got accurate path and line information in the URI I was redirected to.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13047

Differential Revision: https://secure.phabricator.com/D18936
2018-01-26 11:59:48 -08:00
..
audio/basic Add a few more sounds 2017-04-19 13:47:23 -07:00
css Restore bulk edit support for remarkup fields (description, add comment) 2018-01-19 12:45:34 -08:00
externals Hide the Differential scroll objective list on trackpad systems 2017-05-20 07:56:21 -07:00
favicons Revert partial/nonfunctional OpenGraph support 2017-11-22 15:21:10 -08:00
image Uh, update Phabricator login image 2017-08-11 13:37:26 -07:00
js When users click a symbol in Differential to jump to the definition, include path/line context 2018-01-26 11:59:48 -08:00