mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-01 19:22:42 +01:00
02315c4c48
Summary: Ref T13302. The "Close/Cancel" button is currently running two copies of the "dismiss dialog" code, since it's techncally a link with a valid HREF attribute. An alternate formulation of this is perhaps `if (JX.Stratcom.pass()) { return; }` ("let other handlers react to this event; if something kills it, stop processing"), but `pass()` is inherently someone spooky/fragile so try to get away without it. Test Plan: Opened the Javascript console, clicked "Edit Task" on a workboard, clicked "Close" on the dialog. Before: event was double-handled leading to a JS error in the console. After: dialog closes uneventfully. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13302 Differential Revision: https://secure.phabricator.com/D20640 |
||
|---|---|---|
| .. | ||
| __tests__ | ||
| control | ||
| behavior.js | ||
| Cookie.js | ||
| DOM.js | ||
| History.js | ||
| JSON.js | ||
| Leader.js | ||
| Mask.js | ||
| Quicksand.js | ||
| Request.js | ||
| Resource.js | ||
| Routable.js | ||
| Router.js | ||
| Scrollbar.js | ||
| Sound.js | ||
| URI.js | ||
| Vector.js | ||
| WebSocket.js | ||
| Workflow.js | ||