1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00
phorge-phorge/src/aphront
Andre Klapper c1a8b83bd7 Correct PHPDoc or add default return for numerous methods
Summary:
Correct PHPDoc when none of the method calls try to handle a return value.
Add missing fallback `return` statements (which may never be reached if previous condition checks were always true).

This reduces the amount of errors reported by static code analysis tools.

Test Plan: Carefully read the code and check all places in which a function gets called whether a return value is expected.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25650
2024-05-18 21:54:51 +02:00
..
__tests__ Add a test to verify that all routing maps are plausibly valid, and remove some dead routes 2020-02-14 18:06:24 -08:00
configuration Correct PHPDoc or add default return for numerous methods 2024-05-18 21:54:51 +02:00
exception Convert some whiny exceptions into quiet MalformedRequest exceptions 2016-08-16 15:50:21 -07:00
handler Fix a looping workflow when trying to submit a partially-effectless transaction group 2019-05-23 19:16:17 -07:00
headerparser Move lingering "Aphront" classes to Phabricator 2020-02-12 11:50:14 -08:00
httpparametertype Generate file attachment transactions for explicit Remarkup attachments on common edit pathways 2022-05-19 13:21:04 -07:00
interface Allow Controllers to return a wider range of "response-like" objects 2015-09-01 15:52:52 -07:00
multipartparser Move lingering "Aphront" classes to Phabricator 2020-02-12 11:50:14 -08:00
requeststream In Conduit responses, assert that Phabricator supports a "gzip" capability 2020-04-14 16:51:03 -07:00
response Correct spelling mistakes 2023-05-27 22:19:06 +01:00
sink PHP 8.1: fixes for strlen() not accepting NULL anymore, part 2 2023-04-01 15:20:13 +02:00
site PHP 8.1: fixes for strlen() not accepting NULL anymore, part 2 2023-04-01 15:20:13 +02:00
sprite Continue moving classes with no callers in libphutil or Arcanist to Phabricator 2020-02-12 13:14:04 -08:00
writeguard Move lingering "Aphront" classes to Phabricator 2020-02-12 11:50:14 -08:00
AphrontController.php Provide an AphrontController implementation of willSendResponse() 2015-09-07 17:18:35 -07:00
AphrontRequest.php PHP 8.1 "preg_match(null)" exception in javelin/markup.php when http_action not set 2023-04-25 15:45:57 +02:00