Andre Klapper 25aebab655 Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string ... Summary: `::class` is available since PHP 5.5 (5.5 is a minimal requirement by Phorge): https://www.php.net/manual/en/language.oop5.basic.php#language.oop5.basic.class.class It makes finding code using IDEs easier; see discussion in D25500. Thus replace all string return values with returning the `::class` constant instead, with one exception: 'PhabricatorSettingApplication' in `PhabricatorUserPreferencesSearchEngine.php` does not exist and makes arc lint fail so this string remained unchanged. Also note that two occurrences were wrapped in `pht()` for reasons I do not know. List of functions whose return value get updated in this code change: * getApplicationClassName() * getAdapterApplicationClass() * getDatasourceApplicationClass() * getEditorApplicationClass() * getEngineApplicationClass() * getPHIDTypeApplicationClass() * getQueryApplicationClass() cf. T15158 Test Plan: Too broad - click around, basically. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15158 Differential Revision: https://we.phorge.it/D25524		2024-02-05 14:11:36 +01:00
..
PhabricatorAuthContactNumberEditEngine.php	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
PhabricatorAuthContactNumberEditor.php	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
PhabricatorAuthFactorProviderEditEngine.php	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
PhabricatorAuthFactorProviderEditor.php	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
PhabricatorAuthMessageEditEngine.php	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
PhabricatorAuthMessageEditor.php	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
PhabricatorAuthPasswordEditor.php	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
PhabricatorAuthProviderConfigEditor.php	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00
PhabricatorAuthSSHKeyEditor.php	Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string	2024-02-05 14:11:36 +01:00