1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-02 09:58:24 +01:00
phorge-phorge/src/applications/celerity
Andre Klapper c1d86da5b2 Initialize $cache_key variable in CelerityResourceController.php
Summary:
`$cache_key` is unconditionally called in `$cache->setKey($cache_key, $data)` but is only defined if the previous condition `if ($is_cacheable && $is_locally_cacheable && !$dev_mode)` was true.
Thus initialize the variable to avoid a theoretical exception. (No additional null check is needed as `$cache` gets defined in the same condition.)

Test Plan: Carefully read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25642
2024-06-11 13:54:58 +02:00
..
__tests__ Modularize Celerity postprocessors 2015-06-20 06:10:42 -07:00
application Push construction of routing maps into Sites 2015-08-31 04:01:01 -07:00
controller Initialize $cache_key variable in CelerityResourceController.php 2024-06-11 13:54:58 +02:00
management Teach ./bin/celerity about sprite maps 2023-06-03 09:57:05 -07:00
postprocessor Improve remarkup codeblock syntax highlighting when using Dark Mode 2024-03-03 15:58:03 +01:00
resources Remove an old digest in Celerity code and some obsolete configuration options 2019-01-04 13:43:38 -08:00
api.php Make Celerity a real application 2014-10-13 11:17:23 -07:00
CelerityAPI.php Extend from Phobject 2015-06-15 18:02:27 +10:00
CelerityResourceGraph.php Various linter fixes 2015-05-20 07:27:41 +10:00
CelerityResourceMap.php Don't cache resources we can't generate properly 2016-04-21 11:56:54 -07:00
CelerityResourceMapGenerator.php Remove an old digest in Celerity code and some obsolete configuration options 2019-01-04 13:43:38 -08:00
CelerityResourceTransformer.php Swap charts from gRaphael to D3 2016-02-01 10:36:59 -08:00
CeleritySpriteGenerator.php Update Phabricator logo 2016-08-07 11:35:21 -07:00
CelerityStaticResourceResponse.php Emit a "Content-Security-Policy" HTTP header 2018-02-27 10:17:30 -08:00