1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-02 09:58:24 +01:00
phorge-phorge/src/applications/nuance
Andre Klapper 3349c3be17 Fix call to non-existing newWorkCommands() in NuanceItemType
Summary:
rPe1b8532e2478395bd1f36baecb998adeef5bea3d introduced an implementation of `newWorkCommands()` in the child class `NuanceFormItemType` which is called in parent `NuanceItemType::buildWorkCommands()` without being defined in that parent class.
Thus define `newWorkCommands()` as an abstract class in parent class `NuanceItemType` and add an implementation returning null in the other child class `NuanceGitHubEventItemType` to make static code analyzers happy.

Test Plan: Carefully read the code.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25655
2024-06-07 13:30:49 +02:00
..
application Mark "Settings" and "Nuance" as launchable applications 2017-06-01 12:40:25 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
command Allow Nuance commands to try to apply immediately 2017-05-26 08:36:21 -07:00
conduit Import raw GitHub event data into Nuance 2016-03-08 12:03:11 -08:00
contentsource Add a Nuance content source, and make use of it 2016-03-28 12:47:05 -07:00
controller Allow Nuance commands to try to apply immediately 2017-05-26 08:36:21 -07:00
cursor Fix a handful of Nuance fatals 2017-05-24 11:02:55 -07:00
editor Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
github Fix some test suite stragglers with PHP 8.1 compatibility 2022-05-19 12:04:09 -07:00
item Fix call to non-existing newWorkCommands() in NuanceItemType 2024-06-07 13:30:49 +02:00
management Fix PHP 8.1 "strlen(null)" exception for "/bin/nuance update" without parameter 2024-04-17 00:35:44 +02:00
phid Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
query Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
source Remove product literal strings in "pht()", part 7 2022-04-25 12:22:28 -07:00
storage Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface 2018-12-20 15:16:19 -08:00
typeahead Make misc get*ApplicationClass[Name]() calls return ::class constant instead of string 2024-02-05 14:11:36 +01:00
worker Allow Nuance commands to try to apply immediately 2017-05-26 08:36:21 -07:00
xaction Make throwing things into the trash actually work in Nuance 2017-05-24 11:05:30 -07:00