revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/webroot/rsrc/js/application/differential
History
vrana 62a172af90 Fix reticle 
Summary:
Now I understand that [[ https://secure.phabricator.com/diffusion/P/browse/master/webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js;32f12d1f8fb7aeca$174-176 | behavior-edit-inline-comments.js:174-176 ]] and [[ https://secure.phabricator.com/diffusion/P/browse/master/src/applications/differential/controller/changesetview/DifferentialChangesetViewController.php;32f12d1f8fb7aeca$72-99 | DifferentialChangesetViewController.php:72-99 ]] need to stay in sync:

- 1 - isOnRight equals isNewFile
- 1/-1 - left is new, right is missing
- 1/2 - both are new

Test Plan: Hover inline comment.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Maniphest Tasks: T1076

Differential Revision: https://secure.phabricator.com/D2179
2012-04-09 22:09:02 -07:00
..
behavior-accept-with-errors.js Added a big warning if reviewer is about to accept a diff with lint or unit 2011-06-13 11:49:31 -07:00
behavior-add-reviewers-and-ccs.js Use Javelin placeholders and new sorting rules broadly; consolidate tokenizer construction code 2012-03-09 15:46:39 -08:00
behavior-comment-jump.js Added 'Next' and 'Previous' links to differential 2011-05-11 14:46:00 -07:00
behavior-comment-preview.js Improve inline comment previews 2012-03-28 10:11:41 -07:00
behavior-diff-radios.js Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
behavior-dropdown-menus.js Add "View Options" dropdown to Differential / Audit 2012-03-19 19:57:41 -07:00
behavior-edit-inline-comments.js Fix reticle 2012-04-09 22:09:02 -07:00
behavior-keyboard-nav.js Improve inline comment previews 2012-03-28 10:11:41 -07:00
behavior-populate.js Show a tooltip about code coverage 2012-03-12 20:04:12 -07:00
behavior-show-all-comments.js Go to correct position after revealing comments 2012-02-26 13:13:51 -08:00
behavior-show-more.js Show a tooltip about code coverage 2012-03-12 20:04:12 -07:00
DifferentialInlineCommentEditor.js Don't provide Undo for empty text in Differential inline comment 2012-02-29 23:44:42 -08:00