1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 12:12:43 +01:00
phorge-phorge/src/applications/people
epriestley c4856c37e7 Fix content overflow in user hovercards
Summary:
Fixes T13273. This element is a bit weird, but I think I fixed it without breaking anything.

The CSS is used by project hovercards and user hovercards, but they each have a class which builds mostly-shared-but-not-really-identical CSS, instead of having a single `View` class with modes. So I'm not 100% sure I didn't break something obscure, but I couldn't find anything this breaks.

The major issue is that all the text content has "position: absolute". Instead, make the image "absolute" and the text actual positioned content. Then fix all the margins/padding/spacing/layout and add overflow. Seems to work?

Plus: hide availability for disabled users, for consistency with D20342.

Test Plan:
Before:

{F6320155}

After:

{F6320156}

I think this is pixel-exact except for the overflow behavior.

Also:

  - Viewed some other user hovercards, including a disabled user. They all looked unchanged.
  - Viewed some project hovercards. They all looked good, too.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13273

Differential Revision: https://secure.phabricator.com/D20344
2019-03-28 21:10:09 -07:00
..
application Remove the highly suspect "Import from LDAP" workflow 2019-02-12 14:45:58 -08:00
cache Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
capability Add a "Can Disable Users" capability to the "People" application 2018-08-27 08:01:27 -07:00
conduit Deprecate "user.enable" and "user.disable" API methods, redefine them in terms of "user.edit" 2018-08-27 08:00:48 -07:00
config Move "wild" config types to new code 2017-06-27 12:34:56 -07:00
controller Hide "Availability" and "Calendar" on user profiles for disabled users 2019-03-28 17:24:35 -07:00
customfield Hide "Availability" and "Calendar" on user profiles for disabled users 2019-03-28 17:24:35 -07:00
editor Move admin promotions to modular transactions 2018-12-18 10:15:47 -08:00
engine Add Revisions to User Profiles 2017-05-21 09:24:37 -07:00
engineextension Add an "availaiblity" attachment for user.search 2018-12-09 16:41:12 -08:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
guidance Add a bunch of Phacility-specific code to the upstream, thinly veiled as generic code 2016-11-15 09:11:22 -08:00
icon Add additional icons for User Profiles 2016-01-31 20:09:06 +00:00
lipsum Make bin/lipsum generate hanldle generator keys and arguments more clearly 2017-02-27 09:09:28 -08:00
mail Remove one-time login from username change email 2019-02-05 16:01:53 -08:00
management Reduce the cost of generating default user profile images 2018-03-01 16:53:17 -08:00
markup Fix spelling 2017-10-09 10:48:04 -07:00
menuitem Add Revisions to User Profiles 2017-05-21 09:24:37 -07:00
phid Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention 2018-02-06 04:04:52 -08:00
policyrule Move some files around 2015-11-17 06:26:13 +11:00
query Convert simple query subclasses to use internal cursors 2019-03-19 13:00:27 -07:00
search Reduce the amount of boilerplate that implementing FerretInterface requires 2017-09-07 13:23:31 -07:00
searchfield Add basic typechecking support to Conduit 2015-12-14 04:21:39 -08:00
storage Give ExternalAccount a providerConfigPHID, tying it to a particular provider 2019-02-12 14:48:14 -08:00
typeahead Show user availability dots (red = away, orange = busy) in typeaheads, tokenizer tokens, and autocompletes 2019-02-19 10:57:20 -08:00
view Fix content overflow in user hovercards 2019-03-28 21:10:09 -07:00
xaction Remove one-time login from username change email 2019-02-05 16:01:53 -08:00