epriestley 073cb0e78c Make PhabricatorPolicyInterface require a getPHID() method ... Summary: Ref T603. This cleans up an existing callsite in the policy filter, and opens up some stuff in the future. Some policy objects don't have real PHIDs: PhabricatorTokenGiven PhabricatorSavedQuery PhabricatorNamedQuery PhrequentUserTime PhabricatorFlag PhabricatorDaemonLog PhabricatorConduitMethodCallLog ConduitAPIMethod PhabricatorChatLogEvent PhabricatorChatLogChannel Although it would be reasonable to add real PHIDs to some of these (like `ChatLogChannel`), it probably doesn't make much sense for others (`DaemonLog`, `MethodCallLog`). Just let them return `null`. Also remove some duplicate `$id` and `$phid` properties. These are declared on `PhabricatorLiskDAO` and do not need to be redeclared. Test Plan: Ran the `testEverythingImplemented` unit test, which verifies that all classes conform to the interface. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T603 Differential Revision: https://secure.phabricator.com/D7306		2013-10-14 14:35:47 -07:00
..
application	Modernize Countdown somewhat	2013-07-23 06:16:19 -07:00
controller	PHUIPropertyListView	2013-10-11 07:53:56 -07:00
phid	Policy - introduce parentQuery and pass around policy configuration from parent to child	2013-09-11 12:19:34 -07:00
query	Always pass handles to tokenizers, not <phid -> name> maps	2013-10-07 12:51:24 -07:00
remarkup	Modernize Countdown somewhat	2013-07-23 06:16:19 -07:00
storage	Make PhabricatorPolicyInterface require a getPHID() method	2013-10-14 14:35:47 -07:00
view	Modernize Countdown somewhat	2013-07-23 06:16:19 -07:00