1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 17:32:41 +01:00
phorge-phorge/src/applications/releeph
epriestley 073cb0e78c Make PhabricatorPolicyInterface require a getPHID() method
Summary:
Ref T603. This cleans up an existing callsite in the policy filter, and opens up some stuff in the future.

Some policy objects don't have real PHIDs:

  PhabricatorTokenGiven
  PhabricatorSavedQuery
  PhabricatorNamedQuery
  PhrequentUserTime
  PhabricatorFlag
  PhabricatorDaemonLog
  PhabricatorConduitMethodCallLog
  ConduitAPIMethod
  PhabricatorChatLogEvent
  PhabricatorChatLogChannel

Although it would be reasonable to add real PHIDs to some of these (like `ChatLogChannel`), it probably doesn't make much sense for others (`DaemonLog`, `MethodCallLog`). Just let them return `null`.

Also remove some duplicate `$id` and `$phid` properties. These are declared on `PhabricatorLiskDAO` and do not need to be redeclared.

Test Plan: Ran the `testEverythingImplemented` unit test, which verifies that all classes conform to the interface.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T603

Differential Revision: https://secure.phabricator.com/D7306
2013-10-14 14:35:47 -07:00
..
application Provide a history controller for Releeph branches 2013-08-21 12:32:07 -07:00
commitfinder Make most Differential reads policy-aware 2013-09-26 12:37:19 -07:00
conduit Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00
config Partially move Releeph custom fields to PhabricatorCustomField 2013-08-14 12:34:07 -07:00
constants ReleephRequestStatus 2013-05-11 15:20:16 +01:00
controller PHUIPropertyListView 2013-10-11 07:53:56 -07:00
differential Diffusion - move some DiffusionRequest queries to occur over Conduit 2013-05-14 15:32:19 -07:00
editor Add support for more granular sending of email in application transactions 2013-09-13 15:08:17 -07:00
field Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00
mail Remove the last hardcoding from PhabricatorMetaMTAReceivedMail 2013-05-17 10:00:49 -07:00
phid Policy - introduce parentQuery and pass around policy configuration from parent to child 2013-09-11 12:19:34 -07:00
query Always pass handles to tokenizers, not <phid -> name> maps 2013-10-07 12:51:24 -07:00
storage Make PhabricatorPolicyInterface require a getPHID() method 2013-10-14 14:35:47 -07:00
view Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00