mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 03:12:41 +01:00
53f527f71f
Summary:
- Use "preview" instead of "thumb" so we don't get a white background.
- Give this element a darker gutter to separate it a little bit visually.
- Put every thumb on a square hit target.
- Add some color/border/hover stuff.
- Ship down image dimensions.
- Reduce thumb size to 140 so we can fit 2-up on mobile when we get there.
Test Plan:
Before:
{F33545}
After:
{F33546}
Reviewers: chad, ljalonen
Reviewed By: ljalonen
CC: aran
Differential Revision: https://secure.phabricator.com/D5070
426 lines
10 KiB
PHP
426 lines
10 KiB
PHP
<?php
|
|
|
|
final class PhabricatorImageTransformer {
|
|
|
|
public function executeMemeTransform(
|
|
PhabricatorFile $file,
|
|
$upper_text,
|
|
$lower_text) {
|
|
$image = $this->applyMemeTo($file, $upper_text, $lower_text);
|
|
return PhabricatorFile::newFromFileData(
|
|
$image,
|
|
array(
|
|
'name' => 'meme-'.$file->getName(),
|
|
'ttl' => time() + 60 * 60 * 24,
|
|
));
|
|
}
|
|
|
|
public function executeThumbTransform(
|
|
PhabricatorFile $file,
|
|
$x,
|
|
$y) {
|
|
|
|
$image = $this->crudelyScaleTo($file, $x, $y);
|
|
|
|
return PhabricatorFile::newFromFileData(
|
|
$image,
|
|
array(
|
|
'name' => 'thumb-'.$file->getName(),
|
|
));
|
|
}
|
|
|
|
public function executeProfileTransform(
|
|
PhabricatorFile $file,
|
|
$x,
|
|
$min_y,
|
|
$max_y) {
|
|
|
|
$image = $this->crudelyCropTo($file, $x, $min_y, $max_y);
|
|
|
|
return PhabricatorFile::newFromFileData(
|
|
$image,
|
|
array(
|
|
'name' => 'profile-'.$file->getName(),
|
|
));
|
|
}
|
|
|
|
public function executePreviewTransform(
|
|
PhabricatorFile $file,
|
|
$size) {
|
|
|
|
$image = $this->generatePreview($file, $size);
|
|
|
|
return PhabricatorFile::newFromFileData(
|
|
$image,
|
|
array(
|
|
'name' => 'preview-'.$file->getName(),
|
|
));
|
|
}
|
|
|
|
public function executeConpherenceTransform(
|
|
PhabricatorFile $file,
|
|
$top,
|
|
$left,
|
|
$width,
|
|
$height) {
|
|
|
|
$image = $this->crasslyCropTo(
|
|
$file,
|
|
$top,
|
|
$left,
|
|
$width,
|
|
$height);
|
|
|
|
return PhabricatorFile::newFromFileData(
|
|
$image,
|
|
array(
|
|
'name' => 'conpherence-'.$file->getName(),
|
|
));
|
|
}
|
|
|
|
private function crudelyCropTo(PhabricatorFile $file, $x, $min_y, $max_y) {
|
|
$data = $file->loadFileData();
|
|
$img = imagecreatefromstring($data);
|
|
$sx = imagesx($img);
|
|
$sy = imagesy($img);
|
|
|
|
$scaled_y = ($x / $sx) * $sy;
|
|
if ($scaled_y > $max_y) {
|
|
// This image is very tall and thin.
|
|
$scaled_y = $max_y;
|
|
} else if ($scaled_y < $min_y) {
|
|
// This image is very short and wide.
|
|
$scaled_y = $min_y;
|
|
}
|
|
|
|
$cropped = $this->applyScaleWithImagemagick($file, $x, $scaled_y);
|
|
|
|
if ($cropped != null) {
|
|
return $cropped;
|
|
}
|
|
|
|
$img = $this->applyScaleTo(
|
|
$file,
|
|
$x,
|
|
$scaled_y);
|
|
|
|
return $this->saveImageDataInAnyFormat($img, $file->getMimeType());
|
|
}
|
|
|
|
private function crasslyCropTo(PhabricatorFile $file, $top, $left, $w, $h) {
|
|
$data = $file->loadFileData();
|
|
$src = imagecreatefromstring($data);
|
|
$dst = $this->getBlankDestinationFile($w, $h);
|
|
|
|
$scale = self::getScaleForCrop($file, $w, $h);
|
|
$orig_x = $left / $scale;
|
|
$orig_y = $top / $scale;
|
|
$orig_w = $w / $scale;
|
|
$orig_h = $h / $scale;
|
|
|
|
imagecopyresampled(
|
|
$dst,
|
|
$src,
|
|
0, 0,
|
|
$orig_x, $orig_y,
|
|
$w, $h,
|
|
$orig_w, $orig_h);
|
|
|
|
return $this->saveImageDataInAnyFormat($dst, $file->getMimeType());
|
|
}
|
|
|
|
|
|
/**
|
|
* Very crudely scale an image up or down to an exact size.
|
|
*/
|
|
private function crudelyScaleTo(PhabricatorFile $file, $dx, $dy) {
|
|
$scaled = $this->applyScaleWithImagemagick($file, $dx, $dy);
|
|
|
|
if ($scaled != null) {
|
|
return $scaled;
|
|
}
|
|
|
|
$dst = $this->applyScaleTo($file, $dx, $dy);
|
|
return $this->saveImageDataInAnyFormat($dst, $file->getMimeType());
|
|
}
|
|
|
|
private function getBlankDestinationFile($dx, $dy) {
|
|
$dst = imagecreatetruecolor($dx, $dy);
|
|
imagesavealpha($dst, true);
|
|
imagefill($dst, 0, 0, imagecolorallocatealpha($dst, 255, 255, 255, 127));
|
|
|
|
return $dst;
|
|
}
|
|
|
|
private function applyScaleTo(PhabricatorFile $file, $dx, $dy) {
|
|
$data = $file->loadFileData();
|
|
$src = imagecreatefromstring($data);
|
|
|
|
$x = imagesx($src);
|
|
$y = imagesy($src);
|
|
|
|
$scale = min(($dx / $x), ($dy / $y), 1);
|
|
|
|
$sdx = $scale * $x;
|
|
$sdy = $scale * $y;
|
|
|
|
$dst = $this->getBlankDestinationFile($dx, $dy);
|
|
imagesavealpha($dst, true);
|
|
imagefill($dst, 0, 0, imagecolorallocatealpha($dst, 255, 255, 255, 127));
|
|
|
|
imagecopyresampled(
|
|
$dst,
|
|
$src,
|
|
($dx - $sdx) / 2, ($dy - $sdy) / 2,
|
|
0, 0,
|
|
$sdx, $sdy,
|
|
$x, $y);
|
|
|
|
return $dst;
|
|
|
|
}
|
|
|
|
public static function getPreviewDimensions(PhabricatorFile $file, $size) {
|
|
$metadata = $file->getMetadata();
|
|
$x = idx($metadata, PhabricatorFile::METADATA_IMAGE_WIDTH);
|
|
$y = idx($metadata, PhabricatorFile::METADATA_IMAGE_HEIGHT);
|
|
|
|
if (!$x || !$y) {
|
|
$data = $file->loadFileData();
|
|
$src = imagecreatefromstring($data);
|
|
|
|
$x = imagesx($src);
|
|
$y = imagesy($src);
|
|
}
|
|
|
|
$scale = min($size / $x, $size / $y, 1);
|
|
|
|
$dx = max($size / 4, $scale * $x);
|
|
$dy = max($size / 4, $scale * $y);
|
|
|
|
$sdx = $scale * $x;
|
|
$sdy = $scale * $y;
|
|
|
|
return array(
|
|
'x' => $x,
|
|
'y' => $y,
|
|
'dx' => $dx,
|
|
'dy' => $dy,
|
|
'sdx' => $sdx,
|
|
'sdy' => $sdy
|
|
);
|
|
}
|
|
|
|
public static function getScaleForCrop(
|
|
PhabricatorFile $file,
|
|
$des_width,
|
|
$des_height) {
|
|
|
|
$metadata = $file->getMetadata();
|
|
$width = $metadata[PhabricatorFile::METADATA_IMAGE_WIDTH];
|
|
$height = $metadata[PhabricatorFile::METADATA_IMAGE_HEIGHT];
|
|
|
|
if ($height < $des_height) {
|
|
$scale = $height / $des_height;
|
|
} else if ($width < $des_width) {
|
|
$scale = $width / $des_width;
|
|
} else {
|
|
$scale_x = $des_width / $width;
|
|
$scale_y = $des_height / $height;
|
|
$scale = max($scale_x, $scale_y);
|
|
}
|
|
|
|
return $scale;
|
|
}
|
|
private function generatePreview(PhabricatorFile $file, $size) {
|
|
$data = $file->loadFileData();
|
|
$src = imagecreatefromstring($data);
|
|
|
|
$dimensions = self::getPreviewDimensions($file, $size);
|
|
$x = $dimensions['x'];
|
|
$y = $dimensions['y'];
|
|
$dx = $dimensions['dx'];
|
|
$dy = $dimensions['dy'];
|
|
$sdx = $dimensions['sdx'];
|
|
$sdy = $dimensions['sdy'];
|
|
|
|
$dst = $this->getBlankDestinationFile($dx, $dy);
|
|
|
|
imagecopyresampled(
|
|
$dst,
|
|
$src,
|
|
($dx - $sdx) / 2, ($dy - $sdy) / 2,
|
|
0, 0,
|
|
$sdx, $sdy,
|
|
$x, $y);
|
|
|
|
return $this->saveImageDataInAnyFormat($dst, $file->getMimeType());
|
|
}
|
|
|
|
private function applyMemeTo(
|
|
PhabricatorFile $file,
|
|
$upper_text,
|
|
$lower_text) {
|
|
$data = $file->loadFileData();
|
|
$img = imagecreatefromstring($data);
|
|
$phabricator_root = dirname(phutil_get_library_root('phabricator'));
|
|
$font_root = $phabricator_root.'/resources/font/';
|
|
$font_path = $font_root.'tuffy.ttf';
|
|
if (Filesystem::pathExists($font_root.'impact.ttf')) {
|
|
$font_path = $font_root.'impact.ttf';
|
|
}
|
|
$text_color = imagecolorallocate($img, 255, 255, 255);
|
|
$border_color = imagecolorallocatealpha($img, 0, 0, 0, 110);
|
|
$border_width = 4;
|
|
$font_max = 200;
|
|
$font_min = 5;
|
|
for ($i = $font_max; $i > $font_min; $i--) {
|
|
$fit = $this->doesTextBoundingBoxFitInImage(
|
|
$img,
|
|
$upper_text,
|
|
$i,
|
|
$font_path);
|
|
if ($fit['doesfit']) {
|
|
$x = ($fit['imgwidth'] - $fit['txtwidth']) / 2;
|
|
$y = $fit['txtheight'] + 10;
|
|
$this->makeImageWithTextBorder($img,
|
|
$i,
|
|
$x,
|
|
$y,
|
|
$text_color,
|
|
$border_color,
|
|
$border_width,
|
|
$font_path,
|
|
$upper_text);
|
|
break;
|
|
}
|
|
}
|
|
for ($i = $font_max; $i > $font_min; $i--) {
|
|
$fit = $this->doesTextBoundingBoxFitInImage($img,
|
|
$lower_text, $i, $font_path);
|
|
if ($fit['doesfit']) {
|
|
$x = ($fit['imgwidth'] - $fit['txtwidth']) / 2;
|
|
$y = $fit['imgheight'] - 10;
|
|
$this->makeImageWithTextBorder(
|
|
$img,
|
|
$i,
|
|
$x,
|
|
$y,
|
|
$text_color,
|
|
$border_color,
|
|
$border_width,
|
|
$font_path,
|
|
$lower_text);
|
|
break;
|
|
}
|
|
}
|
|
return $this->saveImageDataInAnyFormat($img, $file->getMimeType());
|
|
}
|
|
|
|
private function makeImageWithTextBorder($img, $font_size, $x, $y,
|
|
$color, $stroke_color, $bw, $font, $text) {
|
|
$angle = 0;
|
|
$bw = abs($bw);
|
|
for ($c1 = $x - $bw; $c1 <= $x + $bw; $c1++) {
|
|
for ($c2 = $y - $bw; $c2 <= $y + $bw; $c2++) {
|
|
if (!(($c1 == $x - $bw || $x + $bw) &&
|
|
$c2 == $y - $bw || $c2 == $y + $bw)) {
|
|
$bg = imagettftext($img, $font_size,
|
|
$angle, $c1, $c2, $stroke_color, $font, $text);
|
|
}
|
|
}
|
|
}
|
|
imagettftext($img, $font_size, $angle,
|
|
$x , $y, $color , $font, $text);
|
|
}
|
|
|
|
private function doesTextBoundingBoxFitInImage($img,
|
|
$text, $font_size, $font_path) {
|
|
// Default Angle = 0
|
|
$angle = 0;
|
|
|
|
$bbox = imagettfbbox($font_size, $angle, $font_path, $text);
|
|
$text_height = abs($bbox[3] - $bbox[5]);
|
|
$text_width = abs($bbox[0] - $bbox[2]);
|
|
return array(
|
|
"doesfit" => ($text_height * 1.05 <= imagesy($img) / 2
|
|
&& $text_width * 1.05 <= imagesx($img)),
|
|
"txtwidth" => $text_width,
|
|
"txtheight" => $text_height,
|
|
"imgwidth" => imagesx($img),
|
|
"imgheight" => imagesy($img),
|
|
);
|
|
}
|
|
|
|
private function saveImageDataInAnyFormat($data, $preferred_mime = '') {
|
|
switch ($preferred_mime) {
|
|
case 'image/gif': // Gif doesn't support true color
|
|
case 'image/png':
|
|
if (function_exists('imagepng')) {
|
|
ob_start();
|
|
imagepng($data);
|
|
return ob_get_clean();
|
|
}
|
|
break;
|
|
}
|
|
|
|
$img = null;
|
|
|
|
if (function_exists('imagejpeg')) {
|
|
ob_start();
|
|
imagejpeg($data);
|
|
$img = ob_get_clean();
|
|
} else if (function_exists('imagepng')) {
|
|
ob_start();
|
|
imagepng($data);
|
|
$img = ob_get_clean();
|
|
} else if (function_exists('imagegif')) {
|
|
ob_start();
|
|
imagegif($data);
|
|
$img = ob_get_clean();
|
|
} else {
|
|
throw new Exception("No image generation functions exist!");
|
|
}
|
|
|
|
return $img;
|
|
}
|
|
|
|
private function applyScaleWithImagemagick(PhabricatorFile $file, $dx, $dy) {
|
|
|
|
$img_type = $file->getMimeType();
|
|
$imagemagick = PhabricatorEnv::getEnvConfig('files.enable-imagemagick');
|
|
|
|
if ($img_type != 'image/gif' || $imagemagick == false) {
|
|
return null;
|
|
}
|
|
|
|
$data = $file->loadFileData();
|
|
$src = imagecreatefromstring($data);
|
|
|
|
$x = imagesx($src);
|
|
$y = imagesy($src);
|
|
|
|
$scale = min(($dx / $x), ($dy / $y), 1);
|
|
|
|
$sdx = $scale * $x;
|
|
$sdy = $scale * $y;
|
|
|
|
$input = new TempFile();
|
|
Filesystem::writeFile($input, $data);
|
|
|
|
$resized = new TempFile();
|
|
|
|
list($err) = exec_manual(
|
|
'convert %s -coalesce -resize %sX%s\! %s'
|
|
, $input, $sdx, $sdy, $resized);
|
|
|
|
if (!$err) {
|
|
$new_data = Filesystem::readFile($resized);
|
|
return $new_data;
|
|
} else {
|
|
return null;
|
|
}
|
|
|
|
}
|
|
|
|
}
|