1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 11:12:42 +01:00
phorge-phorge/src/infrastructure/storage/lisk
epriestley c52b3c28e1 Remove partial objects from Lisk
Summary:
Ref T4420. This was a performance hack introduced long ago to make typeaheads for users a little cheaper. The idea was that you could load some of an object's columns and skip other ones.

We now always load users on demand, so the cost of loading the whole objects is very small. No other use cases ever arose for this, and it seems unlikely that they will in the future. Remove it all.

Test Plan:
- Grepped for `CONFIG_PARTIAL_OBJECTS`.
- Grepped for `dirtyFields`.
- Grepped for `missingFields`.
- Grepped for `resetDirtyFields`.
- Grepped for `loadColumns`.
- Grepped for `loadColumnsWhere`.
- Grepped for `loadRawDataWhere`.
- Loaded and saved some lisk objects.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4420

Differential Revision: https://secure.phabricator.com/D9895
2014-07-17 15:49:21 -07:00
..
__tests__ Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
LiskDAO.php Remove partial objects from Lisk 2014-07-17 15:49:21 -07:00
LiskDAOSet.php Purge loadRelativeEdges 2013-09-13 11:40:52 -07:00
LiskEphemeralObjectException.php Delete license headers from files 2012-11-05 11:16:51 -08:00
LiskMigrationIterator.php Delete license headers from files 2012-11-05 11:16:51 -08:00
LiskRawMigrationIterator.php Add LiskRawMigrationIterator 2013-06-21 12:55:07 -07:00
PhabricatorDataNotAttachedException.php Use application PHIDs in Releeph, plus more 2013-07-22 12:17:32 -07:00
PhabricatorLiskDAO.php Substantially support character encodings and "Highlight As" in changesets 2014-06-20 11:49:41 -07:00