1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-02 11:42:42 +01:00
phorge-phorge/src/applications/herald/value
epriestley fbfcc37531 Respect token limits for "Assign to" and custom datasource fields in Herald
Summary:
See PHI173. Currently, Herald has an "Assign to" action for tasks, and you can specify custom fields with datasource values (like users or projects) that have a limit (like 1 "Owner", or 12 "Jury Members").

Herald doesn't support these limits right now, so you can write `[ Assign to ][ X, Y, Z ]`. This just means "Assign to X", but make it more clear by actually enforcing the limit in the UI.

Test Plan:
  - Created a "projects" custom field with limit 1.
  - Tried to create actions that 'assign to' or 'set custom field to' more than one thing, got helpfully rebuffed by the UI.
  - Created an "add subscribers" action with more than one value.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18887
2018-01-22 11:54:12 -08:00
..
HeraldEmptyFieldValue.php Support "Select" custom fields in Herald rules 2015-07-16 14:12:54 -07:00
HeraldFieldValue.php Allow Herald rules to add comments 2017-12-18 09:10:57 -08:00
HeraldRemarkupFieldValue.php Allow Herald rules to add comments 2017-12-18 09:10:57 -08:00
HeraldSelectFieldValue.php Support "Select" custom fields in Herald rules 2015-07-16 14:12:54 -07:00
HeraldTextFieldValue.php Support "Select" custom fields in Herald rules 2015-07-16 14:12:54 -07:00
HeraldTokenizerFieldValue.php Respect token limits for "Assign to" and custom datasource fields in Herald 2018-01-22 11:54:12 -08:00