1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
phorge-phorge/webroot/rsrc/js/application/differential
epriestley c544f78015 When a user hits "Reply", then "Cancel" on an inline comment (without typing),
don't show "Undo"

Summary: When a user hits "Reply" on an inline comment, doesn't type anything,
and then hits "Cancel", we incorrectly store the text of the comment the user is
replying to as the "original" text, and then detect that they've changed it when
they immediately cancel. Instead, store empty string as the original text.

Test Plan:
  - Hit "Reply" and then "Cancel" on an inline comment. No undo now.
  - Hit "Reply", typed some text, and then hit "Cancel". Got an undo which
restored my text.

Reviewers: tomo, jungejason, tuomaspelkonen, aran

Reviewed By: aran

CC: aran, tomo

Differential Revision: 879
2011-08-31 12:04:17 -07:00
..
behavior-accept-with-errors.js Added a big warning if reviewer is about to accept a diff with lint or unit 2011-06-13 11:49:31 -07:00
behavior-add-reviewers-and-ccs.js Add an "Add CCs" action to Differential 2011-06-28 06:41:38 -07:00
behavior-comment-jump.js Added 'Next' and 'Previous' links to differential 2011-05-11 14:46:00 -07:00
behavior-comment-preview.js Fix minor CSRF-patch issues. 2011-08-16 14:39:01 -07:00
behavior-diff-radios.js Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
behavior-edit-inline-comments.js When a user hits "Reply", then "Cancel" on an inline comment (without typing), 2011-08-31 12:04:17 -07:00
behavior-keyboard-nav.js Allow "J" and "K" to jump between files in Differential 2011-08-02 11:11:15 -07:00
behavior-populate.js Use Workflow, not Request, for Differential populate/show more requests 2011-07-16 19:15:54 -07:00
behavior-show-all-comments.js Add comment linking to Maniphest and Differential 2011-05-31 11:11:19 -07:00
behavior-show-more.js Use Workflow, not Request, for Differential populate/show more requests 2011-07-16 19:15:54 -07:00
DifferentialInlineCommentEditor.js Fix problem with adding Differential inline comments to the last line of a file 2011-06-11 16:00:37 -07:00