1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-13 10:22:42 +01:00
phorge-phorge/src
epriestley c55de86f0e Return Diffusion diffs through Files, not directly over Conduit
Summary:
Fixes T10423. Ref T11524. This changes `diffusion.rawdiffquery` to return a file PHID instead of a blob of data.

This is better in general, but particularly better for huge diffs (as in T10423) and diffs with non-utf8 data (as in T10423).

Test Plan:
  - Used `bin/differential extract` to extract a latin1 diff, got a clean diff.
  - Used `bin/repository reparse --herald` to rerun herald on a latin1 diff, got a clean result.
  - Pushed latin1 diffs to test commit hooks.
  - Triggered the the too large / too slow logic.
  - Viewed latin1 diffs in Diffusion.
  - Used "blame past this change" in Diffusion to hit the `before` logic.

Reviewers: chad

Reviewed By: chad

Subscribers: eadler

Maniphest Tasks: T10423, T11524

Differential Revision: https://secure.phabricator.com/D16460
2016-08-27 09:11:03 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Use phutil_json_encode() in AphrontResponse to raise better errors 2016-08-26 07:39:22 -07:00
applications Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00
docs Updated the docs so chatbots can use the Conduit API 2016-08-24 19:05:30 -04:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Updated the docs so chatbots can use the Conduit API 2016-08-24 19:05:30 -04:00
view Removing deprecated method calls 2016-08-23 03:26:34 -05:00
__phutil_library_init__.php
__phutil_library_map__.php Return Diffusion diffs through Files, not directly over Conduit 2016-08-27 09:11:03 -07:00