mirror of
https://we.phorge.it/source/phorge.git
synced 2025-01-18 02:31:10 +01:00
c589529155
Summary: rPa76444a8e238f647dc96f756e6c88aa2fafcdbfe updated our 13 year old copy of the mimemailparser library. That included a behaviour change in the library not covered by Phorge code: The library now decodes MIME encoded UTF8 data in headers. Phorge passes that header to the `iconv_mime_decode()` PHP function which does not accept already encoded content. ``` EXCEPTION: (RuntimeException) iconv_mime_decode(): Detected an illegal character in input string at [<arcanist>/src/error/PhutilErrorHandler.php:273] arcanist(head=master, ref.master=29ca3df1122b), phorge(head=master, ref.master=6ec5c88bee24) #0 PhutilErrorHandler::handleError(integer, string, string, integer) #1 iconv_mime_decode(string, integer, string) called at [<arcanist>/src/utils/utils.php:1759] #2 phutil_decode_mime_header(string) called at [<phorge>/scripts/mail/mail_handler.php:64] ``` Closes T15960 Test Plan: * Have an email file called `tmp.mbox` with a UTF-8 encoded `From:` header. In `scripts/mail/mail_handler.php`, replace `file_get_contents('php://stdin')` with `file_get_contents('./tmp.mbox')`. Insert `echo $headers['subject']; echo "\n"; echo $headers['from'];` statements for debugging. Run `php ./mail_handler.php`. Reviewers: O1 Blessed Committers, taavi, valerio.bozzolan Reviewed By: O1 Blessed Committers, taavi, valerio.bozzolan Subscribers: taavi, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15960 Differential Revision: https://we.phorge.it/D25839
99 lines
3 KiB
PHP
Executable file
99 lines
3 KiB
PHP
Executable file
#!/usr/bin/env php
|
|
<?php
|
|
|
|
// NOTE: This script is very oldschool and takes the environment as an argument.
|
|
// Some day, we could take a shot at cleaning this up.
|
|
if ($argc > 1) {
|
|
foreach (array_slice($argv, 1) as $arg) {
|
|
if (!preg_match('/^-/', $arg)) {
|
|
$_SERVER['PHABRICATOR_ENV'] = $arg;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
$root = dirname(dirname(dirname(__FILE__)));
|
|
require_once $root.'/scripts/__init_script__.php';
|
|
require_once $root.'/externals/mimemailparser/Contracts/CharsetManager.php';
|
|
require_once $root.'/externals/mimemailparser/Contracts/Middleware.php';
|
|
require_once $root.'/externals/mimemailparser/Parser.php';
|
|
require_once $root.'/externals/mimemailparser/Charset.php';
|
|
require_once $root.'/externals/mimemailparser/Attachment.php';
|
|
require_once $root.'/externals/mimemailparser/Exception.php';
|
|
require_once $root.'/externals/mimemailparser/Middleware.php';
|
|
require_once $root.'/externals/mimemailparser/MiddlewareStack.php';
|
|
require_once $root.'/externals/mimemailparser/MimePart.php';
|
|
|
|
$args = new PhutilArgumentParser($argv);
|
|
$args->parseStandardArguments();
|
|
$args->parse(
|
|
array(
|
|
array(
|
|
'name' => 'process-duplicates',
|
|
'help' => pht(
|
|
"Process this message, even if it's a duplicate of another message. ".
|
|
"This is mostly useful when debugging issues with mail routing."),
|
|
),
|
|
array(
|
|
'name' => 'env',
|
|
'wildcard' => true,
|
|
),
|
|
));
|
|
|
|
if (!extension_loaded('mailparse')) {
|
|
throw new Exception(
|
|
pht(
|
|
'PhpMimeMailParser for handling incoming mail requires the PHP '.
|
|
'mailparse extension to be installed.'));
|
|
}
|
|
|
|
$parser = new \PhpMimeMailParser\Parser();
|
|
$parser->setText(file_get_contents('php://stdin'));
|
|
|
|
$content = array();
|
|
foreach (array('text', 'html') as $part) {
|
|
$part_body = $parser->getMessageBody($part);
|
|
$content[$part] = $part_body;
|
|
}
|
|
|
|
$headers = $parser->getHeaders();
|
|
|
|
if ($args->getArg('process-duplicates')) {
|
|
$headers['message-id'] = Filesystem::readRandomCharacters(64);
|
|
}
|
|
|
|
$received = new PhabricatorMetaMTAReceivedMail();
|
|
$received->setHeaders($headers);
|
|
$received->setBodies($content);
|
|
|
|
$attachments = array();
|
|
foreach ($parser->getAttachments() as $attachment) {
|
|
if (preg_match('@text/(plain|html)@', $attachment->getContentType()) &&
|
|
$attachment->getContentDisposition() == 'inline') {
|
|
// If this is an "inline" attachment with some sort of text content-type,
|
|
// do not treat it as a file for attachment. MimeMailParser already picked
|
|
// it up in the getMessageBody() call above. We still want to treat 'inline'
|
|
// attachments with other content types (e.g., images) as attachments.
|
|
continue;
|
|
}
|
|
|
|
$file = PhabricatorFile::newFromFileData(
|
|
$attachment->getContent(),
|
|
array(
|
|
'name' => $attachment->getFilename(),
|
|
'viewPolicy' => PhabricatorPolicies::POLICY_NOONE,
|
|
));
|
|
$attachments[] = $file->getPHID();
|
|
}
|
|
|
|
try {
|
|
$received->setAttachments($attachments);
|
|
$received->save();
|
|
$received->processReceivedMail();
|
|
} catch (Exception $e) {
|
|
$received
|
|
->setMessage(pht('EXCEPTION: %s', $e->getMessage()))
|
|
->save();
|
|
|
|
throw $e;
|
|
}
|