1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 01:02:42 +01:00
phorge-phorge/webroot
Sergey Sharybin 83ab275b0f Fix JavaScript exception when having users with special names
Summary:
The issue was noticed in Firefox when user with login "watch"
was registered in the database. And it was caused by Object
in Firefox having "watch" method.

Solved by checking for whether lookup object does have own
property before using it as a map key.

Test Plan:
To test the issue simply create a user with login "watch",
open the phabricator site in Firefox and try to assign any
maniphest task to this user. You'll see exception being
printed to the javascript console (in my case it's printed
to firebug console).

Reviewers: #blessed_reviewers, epriestley

Reviewed By: epriestley

CC: epriestley, aran

Differential Revision: https://secure.phabricator.com/D8037
2014-01-22 09:10:30 -08:00
..
rsrc Fix JavaScript exception when having users with special names 2014-01-22 09:10:30 -08:00
favicon.ico Improve Phabricator favicon 2011-06-13 18:03:03 -07:00
index.php Improve exception reporting behavior for core exceptions 2014-01-21 14:03:09 -08:00