1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 15:22:41 +01:00
phorge-phorge/src
epriestley c65b58b21c Clean up a ConduitException around Diffusion merges
Summary:
Ref T7123. Two general issues:

For proxied repositories, we currently throw a ConduitClientException, vs ConduitException for local repositories. This is inconsistent and we should fix it, but I also want to examine the use of try-the-call-and-throw at these sites since it may be something we can update. In particular, trying a call that we know will always fail is now more expensive (in proxied repositories) than it used to be.

Here, we try-and-throw for merges, but they're //never// supported in Subversion. Just don't bother trying.

Test Plan: Browsed a SVN repository with proxying set up, got a clean commit page.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7123

Differential Revision: https://secure.phabricator.com/D11646
2015-02-03 09:54:32 -08:00
..
__tests__ Use PhutilLibraryTestCase 2015-01-07 07:38:08 +11:00
aphront PHUIErrorView 2015-02-01 20:14:56 -08:00
applications Clean up a ConduitException around Diffusion merges 2015-02-03 09:54:32 -08:00
docs OAuthServer - harden things up a bit 2015-01-09 11:04:18 -08:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Use PhutilXHPASTBinary methods 2015-02-03 06:59:16 +11:00
view Add smarter UI for form errors 2015-02-03 07:08:59 -08:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php Add a setup warning for calls to deprecated Conduit methods 2015-02-02 14:19:10 -08:00