1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 05:50:55 +01:00
phorge-phorge/webroot/rsrc/js
epriestley c666cb9f0b Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
Summary:
Ref T13513. See PHI1734, which raises a concern about the performance of large revisions near the 100-change threshold.

Currently, `getInlines()` is called whenever the scroll position transitions between two changesets, and it performs a relatively complicated DOM scan to lift inlines out of the document.

This shows up as taking a small but nontrivial amount of time in Firefox profiles and should be safely memoizable.

Test Plan:
  - Under Firefox profiling, scrolled through a large revision.
  - Before change: `getInlines()` appeared as the highest-cost thing we're explicitly doing on profiles.
  - After change: `getInlines()` was no longer meaningfully represented on profiles.
  - Created inlines, edited inlines, etc. Didn't identify any broken behavior.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21261
2020-05-15 09:37:41 -07:00
..
application Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions 2020-05-15 09:37:41 -07:00
core Fix a flash of document selection when "oncopy" and "inline on range" behaviors interact 2020-05-14 14:29:46 -07:00
phui Glue the new FormationView on top of the older Filetree view in Differential 2020-04-22 08:29:04 -07:00
phuix Allow users to create inline comments by directly selecting text directly 2020-05-13 17:15:18 -07:00