mirror of
https://we.phorge.it/source/phorge.git
synced 2025-03-25 10:40:16 +01:00
c7af663523
Summary: Ref T2543. Most actions are not available for drafts. Authors can "Request Review" (move out of draft to become a normal revision) or "Abandon". Non-authors can't do anything (maybe we'll let them do something later -- like "Commandeer"? -- if there's a good reason). Test Plan: Viewed a draft revision as an author and non-author, saw fewer actions available. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T2543 Differential Revision: https://secure.phabricator.com/D18626
81 lines
2.1 KiB
PHP
81 lines
2.1 KiB
PHP
<?php
|
|
|
|
final class DifferentialRevisionRequestReviewTransaction
|
|
extends DifferentialRevisionActionTransaction {
|
|
|
|
const TRANSACTIONTYPE = 'differential.revision.request';
|
|
const ACTIONKEY = 'request-review';
|
|
|
|
protected function getRevisionActionLabel() {
|
|
return pht('Request Review');
|
|
}
|
|
|
|
protected function getRevisionActionDescription(
|
|
DifferentialRevision $revision) {
|
|
if ($revision->isDraft()) {
|
|
return pht('This revision will be submitted to reviewers for feedback.');
|
|
} else {
|
|
return pht('This revision will be returned to reviewers for feedback.');
|
|
}
|
|
}
|
|
|
|
public function getColor() {
|
|
return 'sky';
|
|
}
|
|
|
|
protected function getRevisionActionOrder() {
|
|
return 200;
|
|
}
|
|
|
|
public function getActionName() {
|
|
return pht('Requested Review');
|
|
}
|
|
|
|
public function generateOldValue($object) {
|
|
return $object->isNeedsReview();
|
|
}
|
|
|
|
public function applyInternalEffects($object, $value) {
|
|
$status_review = DifferentialRevisionStatus::NEEDS_REVIEW;
|
|
$object->setModernRevisionStatus($status_review);
|
|
}
|
|
|
|
protected function validateAction($object, PhabricatorUser $viewer) {
|
|
if ($object->isNeedsReview()) {
|
|
throw new Exception(
|
|
pht(
|
|
'You can not request review of this revision because this '.
|
|
'revision is already under review and the action would have '.
|
|
'no effect.'));
|
|
}
|
|
|
|
if ($object->isClosed()) {
|
|
throw new Exception(
|
|
pht(
|
|
'You can not request review of this revision because it has '.
|
|
'already been closed. You can only request review of open '.
|
|
'revisions.'));
|
|
}
|
|
|
|
if (!$this->isViewerRevisionAuthor($object, $viewer)) {
|
|
throw new Exception(
|
|
pht(
|
|
'You can not request review of this revision because you are not '.
|
|
'the author of the revision.'));
|
|
}
|
|
}
|
|
|
|
public function getTitle() {
|
|
return pht(
|
|
'%s requested review of this revision.',
|
|
$this->renderAuthor());
|
|
}
|
|
|
|
public function getTitleForFeed() {
|
|
return pht(
|
|
'%s requested review of %s.',
|
|
$this->renderAuthor(),
|
|
$this->renderObject());
|
|
}
|
|
|
|
}
|