mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-26 07:20:57 +01:00
7f11e8d740
Summary:
Small step forward which improves existing stuff or lays groudwork for future stuff:
- Currently, to check for email verification, we have to single-query the email address on every page. Instead, denoramlize it into the user object.
- Migrate all the existing users.
- When the user verifies an email, mark them as `isEmailVerified` if the email is their primary email.
- Just make the checks look at the `isEmailVerified` field.
- Add a new check, `isUserActivated()`, to cover email-verified plus disabled. Currently, a non-verified-but-not-disabled user could theoretically use Conduit over SSH, if anyone deployed it. Tighten that up.
- Add an `isApproved` flag, which is always true for now. In a future diff, I want to add a default-on admin approval queue for new accounts, to prevent configuration mistakes. The way it will work is:
- When the queue is enabled, registering users are created with `isApproved = false`.
- Admins are sent an email, "[Phabricator] New User Approval (alincoln)", telling them that a new user is waiting for approval.
- They go to the web UI and approve the user.
- Manually-created accounts are auto-approved.
- The email will have instructions for disabling the queue.
I think this queue will be helpful for new installs and give them peace of mind, and when you go to disable it we have a better opportunity to warn you about exactly what that means.
Generally, I want to improve the default safety of registration, since if you just blindly coast through the path of least resistance right now your install ends up pretty open, and realistically few installs are on VPNs.
Test Plan:
- Ran migration, verified `isEmailVerified` populated correctly.
- Created a new user, checked DB for verified (not verified).
- Verified, checked DB (now verified).
- Used Conduit, People, Diffusion.
Reviewers: btrahan
Reviewed By: btrahan
CC: chad, aran
Differential Revision: https://secure.phabricator.com/D7572
68 lines
1.9 KiB
PHP
68 lines
1.9 KiB
PHP
<?php
|
|
|
|
final class PhabricatorMustVerifyEmailController
|
|
extends PhabricatorAuthController {
|
|
|
|
public function shouldRequireLogin() {
|
|
return false;
|
|
}
|
|
|
|
public function shouldRequireEmailVerification() {
|
|
// NOTE: We don't technically need this since PhabricatorController forces
|
|
// us here in either case, but it's more consistent with intent.
|
|
return false;
|
|
}
|
|
|
|
public function processRequest() {
|
|
$request = $this->getRequest();
|
|
$user = $request->getUser();
|
|
|
|
$email = $user->loadPrimaryEmail();
|
|
|
|
if ($email->getIsVerified()) {
|
|
return id(new AphrontRedirectResponse())->setURI('/');
|
|
}
|
|
|
|
$email_address = $email->getAddress();
|
|
|
|
$sent = null;
|
|
if ($request->isFormPost()) {
|
|
$email->sendVerificationEmail($user);
|
|
$sent = new AphrontErrorView();
|
|
$sent->setSeverity(AphrontErrorView::SEVERITY_NOTICE);
|
|
$sent->setTitle(pht('Email Sent'));
|
|
$sent->appendChild(
|
|
pht(
|
|
'Another verification email was sent to %s.',
|
|
phutil_tag('strong', array(), $email_address)));
|
|
}
|
|
|
|
$must_verify = pht(
|
|
'You must verify your email address to login. You should have a '.
|
|
'new email message from Phabricator with verification instructions '.
|
|
'in your inbox (%s).',
|
|
phutil_tag('strong', array(), $email_address));
|
|
|
|
$send_again = pht(
|
|
'If you did not receive an email, you can click the button below '.
|
|
'to try sending another one.');
|
|
|
|
$dialog = id(new AphrontDialogView())
|
|
->setUser($user)
|
|
->setTitle(pht('Check Your Email'))
|
|
->appendParagraph($must_verify)
|
|
->appendParagraph($send_again)
|
|
->addSubmitButton(pht('Send Another Email'));
|
|
|
|
return $this->buildApplicationPage(
|
|
array(
|
|
$sent,
|
|
$dialog,
|
|
),
|
|
array(
|
|
'title' => pht('Must Verify Email'),
|
|
'device' => true
|
|
));
|
|
}
|
|
|
|
}
|