mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-28 17:52:43 +01:00
c8574cf6fd
Summary: Ref T2625. Ref T3794. Ref T418. Ref T1703. This is a more general version of D5278. It expands CustomField support to include real integration with ApplicationSearch. Broadly, custom fields may elect to: - build indicies when objects are updated; - populate ApplicationSearch forms with new controls; - read inputs entered into those controls out of the request; and - apply constraints to search queries. Some utility/helper stuff is provided to make this easier. This part could be cleaner, but seems reasonable for a first cut. In particular, the Query and SearchEngine must manually call all the hooks right now instead of everything happening magically. I think that's fine for the moment; they're pretty easy to get right. Test Plan: I added a new searchable "Company" field to People: {F58229} This also cleaned up the disable/reorder view a little bit: {F58230} As it did before, this field appears on the edit screen: {F58231} However, because it has `search`, it also appears on the search screen: {F58232} When queried, it returns the expected results: {F58233} And the actually good bit of all this is that the query can take advantage of indexes: mysql> explain SELECT * FROM `user` user JOIN `user_customfieldstringindex` `appsearch_0` ON `appsearch_0`.objectPHID = user.phid AND `appsearch_0`.indexKey = 'mk3Ndy476ge6' AND `appsearch_0`.indexValue IN ('phacility') ORDER BY user.id DESC LIMIT 101; +----+-------------+-------------+--------+-------------------+----------+---------+------------------------------------------+------+----------------------------------------------+ | id | select_type | table | type | possible_keys | key | key_len | ref | rows | Extra | +----+-------------+-------------+--------+-------------------+----------+---------+------------------------------------------+------+----------------------------------------------+ | 1 | SIMPLE | appsearch_0 | ref | key_join,key_find | key_find | 232 | const,const | 1 | Using where; Using temporary; Using filesort | | 1 | SIMPLE | user | eq_ref | phid | phid | 194 | phabricator2_user.appsearch_0.objectPHID | 1 | | +----+-------------+-------------+--------+-------------------+----------+---------+------------------------------------------+------+----------------------------------------------+ 2 rows in set (0.00 sec) Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T418, T1703, T2625, T3794 Differential Revision: https://secure.phabricator.com/D6992
148 lines
3.8 KiB
PHP
148 lines
3.8 KiB
PHP
<?php
|
|
|
|
final class PhabricatorPeopleSearchEngine
|
|
extends PhabricatorApplicationSearchEngine {
|
|
|
|
public function getCustomFieldObject() {
|
|
return new PhabricatorUser();
|
|
}
|
|
|
|
public function buildSavedQueryFromRequest(AphrontRequest $request) {
|
|
$saved = new PhabricatorSavedQuery();
|
|
|
|
$saved->setParameter('usernames', $request->getStrList('usernames'));
|
|
$saved->setParameter('nameLike', $request->getStr('nameLike'));
|
|
$saved->setParameter('isAdmin', $request->getStr('isAdmin'));
|
|
$saved->setParameter('isDisabled', $request->getStr('isDisabled'));
|
|
$saved->setParameter('isSystemAgent', $request->getStr('isSystemAgent'));
|
|
$saved->setParameter('createdStart', $request->getStr('createdStart'));
|
|
$saved->setParameter('createdEnd', $request->getStr('createdEnd'));
|
|
|
|
$this->readCustomFieldsFromRequest($request, $saved);
|
|
|
|
return $saved;
|
|
}
|
|
|
|
public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
|
|
$query = id(new PhabricatorPeopleQuery())
|
|
->needPrimaryEmail(true);
|
|
|
|
$usernames = $saved->getParameter('usernames', array());
|
|
if ($usernames) {
|
|
$query->withUsernames($usernames);
|
|
}
|
|
|
|
$like = $saved->getParameter('nameLike');
|
|
if ($like) {
|
|
$query->withNameLike($like);
|
|
}
|
|
|
|
$is_admin = $saved->getParameter('isAdmin');
|
|
$is_disabled = $saved->getParameter('isDisabled');
|
|
$is_system_agent = $saved->getParameter('isSystemAgent');
|
|
|
|
if ($is_admin) {
|
|
$query->withIsAdmin(true);
|
|
}
|
|
|
|
if ($is_disabled) {
|
|
$query->withIsDisabled(true);
|
|
}
|
|
|
|
if ($is_system_agent) {
|
|
$query->withIsSystemAgent(true);
|
|
}
|
|
|
|
$start = $this->parseDateTime($saved->getParameter('createdStart'));
|
|
$end = $this->parseDateTime($saved->getParameter('createdEnd'));
|
|
|
|
if ($start) {
|
|
$query->withDateCreatedAfter($start);
|
|
}
|
|
|
|
if ($end) {
|
|
$query->withDateCreatedBefore($end);
|
|
}
|
|
|
|
$this->applyCustomFieldsToQuery($query, $saved);
|
|
|
|
return $query;
|
|
}
|
|
|
|
public function buildSearchForm(
|
|
AphrontFormView $form,
|
|
PhabricatorSavedQuery $saved) {
|
|
|
|
$usernames = $saved->getParameter('usernames', array());
|
|
$like = $saved->getParameter('nameLike');
|
|
|
|
$is_admin = $saved->getParameter('isAdmin');
|
|
$is_disabled = $saved->getParameter('isDisabled');
|
|
$is_system_agent = $saved->getParameter('isSystemAgent');
|
|
|
|
$form
|
|
->appendChild(
|
|
id(new AphrontFormTextControl())
|
|
->setName('usernames')
|
|
->setLabel(pht('Usernames'))
|
|
->setValue(implode(', ', $usernames)))
|
|
->appendChild(
|
|
id(new AphrontFormTextControl())
|
|
->setName('nameLike')
|
|
->setLabel(pht('Name Contains'))
|
|
->setValue($like))
|
|
->appendChild(
|
|
id(new AphrontFormCheckboxControl())
|
|
->setLabel('Role')
|
|
->addCheckbox(
|
|
'isAdmin',
|
|
1,
|
|
pht('Show only Administrators.'),
|
|
$is_admin)
|
|
->addCheckbox(
|
|
'isDisabled',
|
|
1,
|
|
pht('Show only disabled users.'),
|
|
$is_disabled)
|
|
->addCheckbox(
|
|
'isSystemAgent',
|
|
1,
|
|
pht('Show only System Agents.'),
|
|
$is_system_agent));
|
|
|
|
$this->appendCustomFieldsToForm($form, $saved);
|
|
|
|
$this->buildDateRange(
|
|
$form,
|
|
$saved,
|
|
'createdStart',
|
|
pht('Joined After'),
|
|
'createdEnd',
|
|
pht('Joined Before'));
|
|
}
|
|
|
|
protected function getURI($path) {
|
|
return '/people/'.$path;
|
|
}
|
|
|
|
public function getBuiltinQueryNames() {
|
|
$names = array(
|
|
'all' => pht('All'),
|
|
);
|
|
|
|
return $names;
|
|
}
|
|
|
|
public function buildSavedQueryFromBuiltin($query_key) {
|
|
$query = $this->newSavedQuery();
|
|
$query->setQueryKey($query_key);
|
|
|
|
switch ($query_key) {
|
|
case 'all':
|
|
return $query;
|
|
}
|
|
|
|
return parent::buildSavedQueryFromBuiltin($query_key);
|
|
}
|
|
|
|
}
|