1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/releeph
epriestley 6a2e27ba8d Put all DifferentialComment loading behind DifferentialCommentQuery
Summary:
Ref T2222.

I'm thinking about how I want to approach the Asana sync, and I want to try to do T2222 first so that we can build it cleanly on top of ApplicationTransactions. I think we can at least walk down this road a little bit and if it turns out to be scary we can take another approach.

I was generally very happy with how the auth migration turned out (seemingly, it was almost completely clean), and want to pursue a similar strategy here. Basically:

  - Wrap the new objects in the old objects for reads/writes.
  - Migrate all the existing data to the new table.
  - Everything hard is done; move things over a piece at a time at a leisurely pace in lots of smallish, relatively-easy-to-understand changes.

This deletes or abstracts all reads of the DifferentialComment table. In particular, these things are **deleted**:

  - The script `undo_commits.php`, which I haven't pointed anyone at in a very long time.
  - The `differential.getrevisionfeedback` Conduit method, which has been marked deprecated for a year or more.
  - The `/stats/` interface in Differential, which should be rebuilt on Fact and has never been exposed in the UI. It does a ton of joins and such which are prohibitively difficult to migrate.

This leaves a small number of reading interfaces, which I replaced with a new `DifferentialCommentQuery`. Some future change will make this actually load transactions and wrap them with DifferentialComment interfaces.

Test Plan: Viewed a revision; made revision comments

Reviewers: btrahan

Reviewed By: btrahan

CC: edward, chad, aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D6260
2013-06-21 12:51:18 -07:00
..
application ReleephRequest xactions 2013-05-11 15:20:09 +01:00
commitfinder Diffusion - move some DiffusionRequest queries to occur over Conduit 2013-05-14 15:32:19 -07:00
conduit Diffusion - move some DiffusionRequest queries to occur over Conduit 2013-05-14 15:32:19 -07:00
config Releeph (Phabricator part) 2013-03-15 11:28:43 +00:00
constants ReleephRequestStatus 2013-05-11 15:20:16 +01:00
controller PHUIList, PHUIDocument updates 2013-06-05 08:41:43 -07:00
differential Diffusion - move some DiffusionRequest queries to occur over Conduit 2013-05-14 15:32:19 -07:00
editor Releeph: use relative URIs 2013-05-22 15:42:30 +01:00
field Put all DifferentialComment loading behind DifferentialCommentQuery 2013-06-21 12:51:18 -07:00
mail Remove the last hardcoding from PhabricatorMetaMTAReceivedMail 2013-05-17 10:00:49 -07:00
query Add loadObject() methods to PhabricatorObjectMailReceiver subclasses 2013-05-17 03:47:46 -07:00
storage Releeph: use relative URIs 2013-05-22 15:42:30 +01:00
view Provide a concrete class for one-off remarkup blocks 2013-05-24 12:37:53 -07:00
ReleephObjectHandleLoader.php Releeph (Phabricator part) 2013-03-15 11:28:43 +00:00
ReleephPHIDConstants.php Releeph (Phabricator part) 2013-03-15 11:28:43 +00:00